Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TomcatHttpHandlerAdapter is not aware of Server[Request|Response]Wrapper [SPR-17611] #22143

Closed
spring-issuemaster opened this issue Dec 19, 2018 · 1 comment
Assignees
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Dec 19, 2018

Arjen Poutsma opened SPR-17611 and commented

In TomcatServerHttpRequest#createTomcatHttpHeaders, it is assumed that the given HttpServletRequest is a org.apache.catalina.connector.RequestFacade, while it could be a HttpServletRequestWrapper. Similarly, TomcatServerHttpResponse#createTomcatHttpHeaders assumes that the given response is a ResponseFacade, while it could be a HttpServletResponseWrapper.


Affects: 5.1.3

Reference URL: spring-projects/spring-boot#15489

Referenced from: commits 5e4a896

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 19, 2018

Arjen Poutsma commented

Fixed in 5e4a896

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.