Skip to content

/ spring-framework

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document effect of preemptive timeouts on transactional tests [SPR-17647] #22176

Closed
spring-projects-issues opened this issue Jan 8, 2019 · 2 comments
Closed

Document effect of preemptive timeouts on transactional tests [SPR-17647] #22176

spring-projects-issues opened this issue Jan 8, 2019 · 2 comments
Assignees
@sbrannen
Labels
in: test type: documentation
Milestone
5.1.5

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Jan 8, 2019 •
edited

Sam Brannen opened SPR-17647 and commented

Overview

As discussed in JUnit 5 issue 1701, developers are often unaware of the effect that a preemptive timeout in a testing framework can have on transactional tests in Spring.

Documenting such use cases in the Testing chapter of the Spring Reference Manual, analogous to how I documented it in the JUnit 5 User Guide, would help improve awareness.

Deliverables

  • Document effect of preemptive timeouts on transactional tests in the Testing chapter.
  • Mention JUnit Jupiter's assertTimeoutPreemptively().
  • Mention JUnit 4's Timeout rule and timeout support.
  • Mention TestNG's timeOut support.

Reference URL: junit-team/junit5#1701

Issue Links:

  • #10792 Support timed transactional TestNG tests in the TestContext framework

Referenced from: commits e1e6224, df13e4d
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 9, 2019 •
edited

Sam Brannen commented

This is closely related to #10792.
@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 9, 2019

Sam Brannen commented

This has been documented in the following commits.
@spring-projects-issues spring-projects-issues added this to the 5.1.5 milestone Jan 11, 2019
Closed
0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sbrannen sbrannen

Labels
in: test type: documentation
Projects
None yet
Milestone
5.1.5
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@sbrannen @spring-projects-issues
You can’t perform that action at this time.