Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align implementations of StringToUUIDConverter and UUIDEditor #23940

Closed
sbrannen opened this issue Nov 6, 2019 · 0 comments
Closed

Align implementations of StringToUUIDConverter and UUIDEditor #23940

sbrannen opened this issue Nov 6, 2019 · 0 comments
Assignees
Milestone

Comments

@sbrannen
Copy link
Member

@sbrannen sbrannen commented Nov 6, 2019

Overview

UUIDEditor checks if the supplied value hasText; whereas, StringToUUIDConverter checks if the supplied value hasLength. Similarly, StringToUUIDConverter trims the supplied value, but UUIDEditor does not.

Deliverables

  • Switch to StringUtils.hasText in StringToUUIDConverter to align with the behavior of UUIDEditor.
  • Use String#trim() in UUIDEditor to align with the behavior of StringToUUIDConverter.
@sbrannen sbrannen self-assigned this Nov 6, 2019
@sbrannen sbrannen added this to the 5.2.2 milestone Nov 6, 2019
@sbrannen sbrannen closed this in 29b31ca Nov 6, 2019
@sbrannen sbrannen changed the title Align empty value semantics of StringToUUIDConverter with UUIDEditor Align implementations of StringToUUIDConverter and UUIDEditor Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.