Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSocketRequester allows specifying data more than once #24073

Closed
rstoyanchev opened this issue Nov 25, 2019 · 0 comments
Closed

RSocketRequester allows specifying data more than once #24073

rstoyanchev opened this issue Nov 25, 2019 · 0 comments
Assignees
Milestone

Comments

@rstoyanchev
Copy link
Contributor

@rstoyanchev rstoyanchev commented Nov 25, 2019

#23649 merged RSocketRequester.RequestSpec and RSocketRequester.ResponseSpec into one and as a consequence the below is now possible which would send the 3rd data value "Hello 3" as the payload data and ignore the first two:

Flux<String> result = requester.route("route")
    .data("Hello 1")
    .data("Hello 2")
    .data("Hello 3")
    .retrieveFlux(String.class);

This was not an intended consequence that should not have been introduced. This issue is to correct it and ensure that after the first call to data, it is only possible to see the options for retrieving the response.

@rstoyanchev rstoyanchev added this to the 5.2.2 milestone Nov 25, 2019
@rstoyanchev rstoyanchev self-assigned this Nov 25, 2019
artembilan added a commit to spring-projects/spring-integration that referenced this issue Nov 25, 2019
sdeleuze added a commit to sdeleuze/spring-framework that referenced this issue Dec 9, 2019
After spring-projectsgh-24073, some Coroutines extensions should be applied on
RetrieveSpec instead of RequestSpec.

Closes spring-projectsgh-24166
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.