Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distributions no longer deployed #24605

Closed
JohnZ1385 opened this issue Feb 27, 2020 · 10 comments
Closed

Distributions no longer deployed #24605

JohnZ1385 opened this issue Feb 27, 2020 · 10 comments
Assignees
Labels
type: regression A bug that is also a regression
Milestone

Comments

@JohnZ1385
Copy link

Usually I can find a full dist of the spring releases at:
https://maven.springframework.org/release/org/springframework/spring/
5.2.4 does not seem to have been posted despite most of the modules now being available on Maven central.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 27, 2020
@snicoll
Copy link
Member

snicoll commented Feb 27, 2020

Thanks for the report @JohnZ1385. This looks like a regression introduced by a change in our build script.

FTR, the canonical url for that repo is https://repo.spring.io/release/org/springframework/spring/

@snicoll snicoll added type: regression A bug that is also a regression and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Feb 27, 2020
@snicoll snicoll added this to the 5.2.5 milestone Feb 27, 2020
@snicoll snicoll changed the title Spring 5.2.4 full dist Distributions no longer deployed Feb 27, 2020
@bclozel
Copy link
Member

bclozel commented Feb 28, 2020

The last successful SNAPSHOT deploy was done on February 7th, which leads me to think that the repository declaration done in 02e90a8 might have something to do with this problem.

@sbrannen
Copy link
Member

The last successful SNAPSHOT deploy was done on February 7th, which leads me to think that the repository declaration done in 02e90a8 might have something to do with this problem.

@wilkinsona, thoughts?

@wilkinsona
Copy link
Member

I can’t explain why that repository declaration would cause a publishing problem. The repository declaration should only affect dependency resolution and only dependencies in the io.spring.asciidoctor group at that. It would be particularly bizarre for it to only affect one module as well.

That said, it’s impossible to rule it out as the Bamboo Artifactory integration is a black box that could be doing pretty much anything.

@wilkinsona
Copy link
Member

wilkinsona commented Feb 29, 2020

The build logs show the artifacts being deployed:

build	28-Feb-2020 17:10:46	Deploying artifact: https://repo.spring.io/libs-snapshot-local/io/spring/asciidoctor/spring/5.2.5.BUILD-SNAPSHOT/spring-5.2.5.BUILD-SNAPSHOT-dist.zip
build	28-Feb-2020 17:10:53	Deploying artifact: https://repo.spring.io/libs-snapshot-local/io/spring/asciidoctor/spring/5.2.5.BUILD-SNAPSHOT/spring-5.2.5.BUILD-SNAPSHOT-docs.zip
build	28-Feb-2020 17:10:56	Deploying artifact: https://repo.spring.io/libs-snapshot-local/io/spring/asciidoctor/spring/5.2.5.BUILD-SNAPSHOT/spring-5.2.5.BUILD-SNAPSHOT-schema.zip
build	28-Feb-2020 17:10:56	Deploying artifact: https://repo.spring.io/libs-snapshot-local/io/spring/asciidoctor/spring/5.2.5.BUILD-SNAPSHOT/spring-5.2.5.BUILD-SNAPSHOT.pom

Note the io/spring/asciidoctor path. I can’t explain why that’s happening. It looks like a bug in the Artifactory Bamboo integration where it’s interpreting a restriction on what group should be available from a repository as the group that should be used for publishing. Fixing that is out of our control and may take some time. The quickest option may be to remove the custom repository declaration and copy the Asciidoctor extension into https://repo.spring.io/libs-spring-framework-build instead.

@wilkinsona
Copy link
Member

I can explain it now and it was my fault. Sorry. It should be includeGroup rather than group when configuring the mavenContent.

@sbrannen
Copy link
Member

sbrannen commented Mar 2, 2020

Thanks for figuring out the solution, @wilkinsona! 👍

We'll get that fixed.

@sbrannen sbrannen self-assigned this Mar 2, 2020
@sbrannen
Copy link
Member

Distribution zip files are once again being published.

https://repo.spring.io/snapshot/org/springframework/spring/5.2.5.BUILD-SNAPSHOT/

@snicoll
Copy link
Member

snicoll commented Mar 24, 2020

And the proper zips have been staged for 5.2.5 as well.

@sbrannen
Copy link
Member

And the proper zips have been staged for 5.2.5 as well.

Indeed... staged and now available: https://repo.spring.io/release/org/springframework/spring/5.2.5.RELEASE/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A bug that is also a regression
Projects
None yet
Development

No branches or pull requests

6 participants