Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subclasses of UrlBasedViewResolver could avoid reflection when creating instances of View #25847

Closed
dsyer opened this issue Oct 1, 2020 · 0 comments
Closed

Subclasses of UrlBasedViewResolver could avoid reflection when creating instances of View #25847

dsyer opened this issue Oct 1, 2020 · 0 comments
Assignees
@jhoeller
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Milestone
5.3 RC2

Comments

@dsyer
Copy link
Member

dsyer commented Oct 1, 2020

All subclasses (I think) currently delegate creation of View instances to the parent class, which only knows the View class, so has to instantiate it reflectively. It would be nice for subclasses, which mostly know how to create their own, specific View instances, to be able to provide a Supplier instead, and for that to be the default behaviour.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 1, 2020
@sbrannen sbrannen added in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement labels Oct 1, 2020
@jhoeller jhoeller self-assigned this Oct 1, 2020
@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Oct 1, 2020
@jhoeller jhoeller added this to the 5.3 RC2 milestone Oct 1, 2020
@wilkinsona wilkinsona mentioned this issue Nov 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhoeller jhoeller

Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) type: enhancement A general enhancement
Projects
None yet
Milestone
5.3 RC2
Development

No branches or pull requests
5 participants
@sbrannen @dsyer @sdeleuze @jhoeller @spring-projects-issues