New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyFactoryBean does not work with prototype advisors/interceptors [SPR-328] #5058

Closed
spring-issuemaster opened this Issue Sep 11, 2004 · 2 comments

Comments

Projects
None yet
1 participant
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Sep 11, 2004

Chris Eldredge opened SPR-328 and commented

There are several issues in the ProxyFactoryBean which prevent it from correctly creating beans with prototype advisors:

-Cannot create proxy when using prototype advisor when singleton=false
-Cannot create proxy when using prototype interceptor when singletone=false
-Cannot create proxy when using singleton target and singleton=false (ie, to use a prototype advisor on a singleton target)

Essentially, at the moment the only part of a prototype ProxyFactoryBean which may be a prototype is the target bean.

When trying to use a prototype the following exception is thrown:

BeanCreationException: Error creating bean with name 'prototypeTestBeanProxySingletonTarget' defined in class path resource [proxyFactoryTests.xml]: Initialization of bean failed; nested exception is org.springframework.aop.framework.AopConfigException: TargetSource specified more than once: Specify in targetSource property or at the END of the interceptorNames list
...

Note that in targetSource is not actually specified more than once.

The main defect is that when the factory is initialized, it avoids loading prototype beans which appear in the interceptorNames property in order to improve performance. Instead it substitutes a null value. When this null value is later examined, it cannot be determined whether the bean was supposed to be a target or an advisor.


Affects: 1.1.1

Attachments:

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Sep 11, 2004

Chris Eldredge commented

patch against build 96 which resolves all issues.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Sep 12, 2004

Chris Eldredge commented

Updated patch generated on 13 Sept 2004. For some reason, previous patch does not apply cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment