Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

javadoc missing for ...aop.AfterReturningAdvisor.afterReturning [SPR-474] #5203

Closed
spring-issuemaster opened this issue Nov 18, 2004 · 2 comments
Closed
Milestone

Comments

@spring-issuemaster
Copy link
Collaborator

@spring-issuemaster spring-issuemaster commented Nov 18, 2004

Claus Ibsen opened SPR-474 and commented

I am playing with the AOP stuff and it's really powerful.

I was using the AfterReturningAdvisor to do the trivial logging of what method a given user has performed for a kind of audit log.

There is no javadoc for the method itself on the interface and I am a bit confused what would happend if I thron an exception.

See the javadoc for MethodBeforeAdvice it has full javadoc.

Will the same thing happend if an exception is thrown?

Throwable - if this object wishes to abort the call. Any exception thrown will be returned to the caller if it's allowed by the method signature. Otherwise the exception will be wrapped as a runtime exception.

Hope it's easy to fix for Rod ;)


Affects: 1.1.2

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Nov 18, 2004

Claus Ibsen commented

Oh and org.springframework.aop.framework.AdvisedSupportListener does not have a class javadoc. And thus is blank in the Summary.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

@spring-issuemaster spring-issuemaster commented Dec 8, 2004

Juergen Hoeller commented

Thanks for the report - just added corresponding javadoc. An exception thrown by AfterReturningAdvice will indeed be propagated to the caller, just like an exception thrown by MethodBeforeAdvice.

Juergen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.