New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for jsp taglibs in freemarker templates [SPR-1052] #5759

Closed
spring-issuemaster opened this Issue Jun 17, 2005 · 10 comments

Comments

Projects
None yet
1 participant
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Jun 17, 2005

Kaj Hejer opened SPR-1052 and commented

It would be nice if Spring had support for jsp taglibs like f.x.

<#assign tolog=JspTaglibs["/WEB-INF/jsp/tolog.tld"]>

as decribed on http://fmpp.sourceforge.net/freemarker/pgui_misc_servlet.html (see the heading "Using JSP custom tags in FTL")


Attachments:

4 votes, 7 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Jun 24, 2005

Kaj Hejer commented

There is a thread about this issue in the forum, see http://forum.springframework.org/viewtopic.php?t=905

@spring-issuemaster

This comment has been minimized.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Jul 4, 2005

Tom Turelinckx commented

Source code from the article.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Jul 17, 2005

Tom Turelinckx commented

FYI, I received this email from someone who's been using the code in my article:

Hi Tom,

Just an update on your code to get JspTaglibs working in Spring
Freemarker installations.....

It seems to work flawlessly. I've migrated all of my functionality to
use the code and seen no problems.

It seems to a good piece of work - I encourage you to get this into
Spring, it something I know that I want, something in the Spring JIRA,
and something I know a few other J2EE people want.

Thanks for a fine piece of work,
Dean.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Oct 20, 2005

Erik Pedersen commented

I tested this implementation. I had to create a new view resolver to make this work the way I needed.

It works great.

See:

http://forum.springframework.org/viewtopic.php?t=905&postdays=0&postorder=asc&start=15

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented May 4, 2006

Rob Harrop commented

All,

I updated FreeMarkerView and FreeMarkerConfigurer as appropriate so this should now just work. Can anyone who needs this feature please try it out. I gave it a basic run in a local Tomcat but feedback from a real usage scenario would be great.

Rob

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Jun 20, 2006

Tom Turelinckx commented

Rob,

I've just replaced all usages of TaglibFreeMarkerView with the regular FreeMarkerView in several of our real-world applications which heavily use the taglib functionality, and it seems to work just fine! Waiting for RC1 to deploy into production...

Tom

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Sep 13, 2006

Nick Richards commented

To quote Homer, "Holy Macaroni!". Integrating both Erik's and Tom's code gives me JspTaglibs access in my out of the box spring + freemarker setup. Thanks very much! (and to the rest of the Spring folks too!)

This JspTaglibs support really needs to be made a part of Spring, or made into a filter. Immediately after discovering the no-taglibs limitation with the out of the box Spring integration, I felt like I had to drop FreeMarker...that was a "deal breaker".

I opted to drop Tom's Views.properties and go with Erik's bean config xml. Here's mine:

<bean id="freemarkerConfig" class="org.springframework.web.servlet.view.freemarker.FreeMarkerConfigurer">
  <property name="templateLoaderPath" value="/WEB-INF/ftl/"/>
</bean>

<bean id="freemarkerServletContextModel"
class="springext.web.servlet.view.freemarker.support.ServletContextModelFactoryBean"/>
<bean id="freemarkerTaglibFactory"
class="springext.web.servlet.view.freemarker.support.TaglibFactoryBean"/>
<bean id="viewResolver"
class="springext.web.servlet.view.freemarker.TaglibFreeMarkerViewResolver">
<property name="servletContextModel" ref="freemarkerServletContextModel" />
<property name="taglibFactory" ref="freemarkerTaglibFactory" />
<property name="cache" value="true" />
<property name="prefix" value="" />
<property name="suffix" value=".ftl" />
<property name="exposeSpringMacroHelpers"
value="true" />
</bean>

Nick

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Sep 13, 2006

Nick Richards commented

FYI I am still on 1.2.6, not sure about jumping to 2.0, worried about destabilization.... Cheers.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator Author

spring-issuemaster commented Feb 20, 2007

Waldemar Baraldi commented

I have started a new thread in the forum regarding an issue using this feature.

http://forum.springframework.org/showthread.php?t=35156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment