Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form:select does not provide I18N capabilities [SPR-2512] #7201

Closed
spring-projects-issues opened this issue Aug 30, 2006 · 5 comments
Closed
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: bulk-closed An outdated, unresolved issue that's closed in bulk as part of a cleaning process

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 30, 2006

Jorg Heymans opened SPR-2512 and commented

Rationale:

  1. form:option does not allow bodycontent, so this is impossible:
    form:select
    <c:forEach items="${command.options}" var="o">
    <form:option value="${o.key}">fmt:message key="${o.label}" /></form:option>
    </c:forEach>
    </form:select>

  2. the itemLabel merely resolves a property on an item in items, so that any I18N strings would need to be inserted from the controller already. This sort of works but needs a lot of extra attention from the controller, merely for the sake of i18n which is not desired.

Ideally form:select has an additional attribute, something like "itemLabelsAreKeys=true" that resolves the key before outputting.


Affects: 2.0 RC2

Issue Links:

8 votes, 8 watchers

@spring-projects-issues
Copy link
Collaborator Author

Jorg Heymans commented

note that this applies to spring-2.0-rc2

@spring-projects-issues
Copy link
Collaborator Author

Rick Evans commented

I18N support for the entire gorm tag library is going to be addressed in 2.1 RC1.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues
Copy link
Collaborator Author

Rob Harrop commented

It should be noted that OptionTag does support body content so it itself can be used for i18n purposes right now. As Rick says a more comprehensive i18n solution will be provided in 2.1.

Rob

@spring-projects-issues spring-projects-issues added status: waiting-for-triage An issue we've not yet triaged or decided on type: enhancement A general enhancement in: web Issues in web modules (web, webmvc, webflux, websocket) labels Jan 10, 2019
@spring-projects-issues spring-projects-issues removed the type: enhancement A general enhancement label Jan 11, 2019
@rstoyanchev rstoyanchev added status: bulk-closed An outdated, unresolved issue that's closed in bulk as part of a cleaning process and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jan 11, 2019
@spring-projects-issues
Copy link
Collaborator Author

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web Issues in web modules (web, webmvc, webflux, websocket) status: bulk-closed An outdated, unresolved issue that's closed in bulk as part of a cleaning process
Projects
None yet
Development

No branches or pull requests

2 participants