New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form:select does not provide I18N capabilities [SPR-2512] #7201

Closed
spring-issuemaster opened this Issue Aug 30, 2006 · 5 comments

Comments

Projects
None yet
2 participants
@spring-issuemaster
Copy link
Collaborator

spring-issuemaster commented Aug 30, 2006

Jorg Heymans opened SPR-2512 and commented

Rationale:

  1. form:option does not allow bodycontent, so this is impossible:
    form:select
    <c:forEach items="${command.options}" var="o">
    <form:option value="${o.key}">fmt:message key="${o.label}" /></form:option>
    </c:forEach>
    </form:select>

  2. the itemLabel merely resolves a property on an item in items, so that any I18N strings would need to be inserted from the controller already. This sort of works but needs a lot of extra attention from the controller, merely for the sake of i18n which is not desired.

Ideally form:select has an additional attribute, something like "itemLabelsAreKeys=true" that resolves the key before outputting.


Affects: 2.0 RC2

Issue Links:

  • #6935 Allow body content of form:option to specify label ("depends on")
  • #8047 Provide comprehensive I18N support for the Spring form tag library. ("is depended on by")

8 votes, 8 watchers

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Aug 30, 2006

Jorg Heymans commented

note that this applies to spring-2.0-rc2

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Sep 16, 2006

Rick Evans commented

I18N support for the entire gorm tag library is going to be addressed in 2.1 RC1.

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Sep 27, 2006

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Sep 29, 2006

Rob Harrop commented

It should be noted that OptionTag does support body content so it itself can be used for i18n purposes right now. As Rick says a more comprehensive i18n solution will be provided in 2.1.

Rob

@spring-issuemaster

This comment has been minimized.

Copy link
Collaborator

spring-issuemaster commented Jan 12, 2019

Bulk closing outdated, unresolved issues. Please, reopen if still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment