Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do NOT migrate Spring to purely Maven build. It will be a travesty! [SPR-2599] #7288

Closed
spring-projects-issues opened this issue Sep 18, 2006 · 21 comments
Labels
has: votes-jira Issues migrated from JIRA with more than 10 votes at the time of import in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Sep 18, 2006

Marc Palmer opened SPR-2599 and commented

Ben states in this issue:

http://opensource.atlassian.com/projects/spring/browse/SPR-1484#action_19501

That Spring will be migrating to a purely Maven 2 based build. This could well be a total disaster for Spring. There are many projects that have suffered at the hands of Maven which is revered by some and hated by just as many.

Abandoning pure ANT builds will be a major mistake.

Please feel free to leave comments about your Maven disasters... mine was an inability to build Groovy from source at a critical time in our project because the repository was not available. Stop the Maven Madness!


Affects: 2.0 RC4

22 votes, 7 watchers

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Marc Palmer commented

Don't forget to VOTE for this issue if you want to keep ANT builds and can see through the Maven smokescreen!

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Marc Palmer commented

Exhibit A - Cocoon requires a special page explaining how to work around Maven 2 build problems:

http://cocoon.zones.apache.org/daisy/documentation/g1/1164.html

Why ship products that use broken or vulnerable build systems?

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Rick Evans commented

There you go Ben... the somewhat cool side effect of Marc's issue is that if it gets enough votes to be actioned, then (weirdly) you will have actually have nothing to do.

Rock on!

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Graeme Rocher commented

This ones got my vote. Maven, in my opinion, has been far more hassle than its worth in two projects I have been involved in (Cocoon and Groovy)

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Hani Suleiman commented

Another vote from me. I hope this doesn't make you take this issue less seriously.

Helping maven users is a good thing, hurting others to do so is not the Spring Way. Please let me download spring and build it without needing a network connection or maven.

maven2 works fine for many projects, but ant ALWAYS works, whereas maven (due to either a bad upload, bad network connection, bad poms, bad project setup) tends to fail for me about 30% of the time.

Don't be evil!

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Eugene Kuleshov commented

I'd like to vote against this issue!

Instead of childishly complaining to Spring about Maven issues, you guys should be voting in Maven's Jira, so these issues will be fixed in Maven.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Eugene Kuleshov commented

Oh, by the way, that cocon page about maven issues linked above has actually nothing todo with Maven and just explaining how to get around instability of the ibiblio repository. They could just created their own repository mirror for their dependencies... or just put these mirror settings into cocon poms.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Carlos Sanchez commented

Eugene: to vote aginst, vote in #6183 ;)

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Brian Topping commented

Sorry, this is kind of backwards. Maven creates jars. And jars work with Ant. Moving the build to M2 won't break Ant projects that use the artifacts.

If you don't want to use Maven, don't. Even if you develop for Spring, it's unlikely that you'll ever have to touch Maven, and a lot less likely than having to touch build.xml for the same change.

Ant never "just works", quite the opposite actually. Ant only creates artifacts after laborious tuning of the procedural build file that drives it. This is like saying we shouldn't have EJB 3 because everything is possible without it. At least Maven works for standard layouts out of the box.

This issue gets my -1 as well.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Marc Palmer commented

The implication of the announcement is that Spring will not be downloadable containing all its required dependencies, and will not be buildable from source using a pure ANT build shipped with the product.

If this is indeed correct it will be a major retrograde step.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Carlos Sanchez commented

You are mising apples with oranges, building with maven doesn't prevent bundling all dependencies.
About including an Ant script, well that depends, the same way people building with ant don't provide a makefile

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 18, 2006

Juergen Hoeller commented

Guys, no worries - I'm a dedicated Ant lover myself :-)

From my perspective, this is not so much about Spring core moving to a purely Maven2-related build. Spring core has some specific building and testing requirements that work well now but are rather hard to achieve in Maven. My opinion on this is to never change a working system unless you really gain something significant; this also applies to a build process.

The Maven2 efforts are more about the sister projects (such as Spring Web Flow and Spring Web Services) using Maven2 and relying on mavenized Spring core jars. This is certainly worth doing, since have much more "traditional" dependency structures and building requirements.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 19, 2006

Jason Carreira commented

On the maven Jira, can we create an issue for them to stop development and deprecate it? ;-)

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 19, 2006

Marc Palmer commented

ROFL Jason - genius! It is very amusing to wonder whether or not an open source project would actually listen to a huge number of (former) users and actually discontinue it at the users' request. Ha!

Think of all the time they've put in - they could have made a simpler cleaner build system by now I'm sure! :)

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 20, 2006

Hani Suleiman commented

yeah, nothing wrong with improving the lives of maven users (they deserve a lot of sympathy for what they have to put up with), as long as you don't end up punishing the eise (but silent) majority for the loud and obnoxious minority. Thanks for clarifying Juergen!

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 2, 2006

Geoffrey De Smet commented

-1
I am happy m2 user and ANT vs M2 feels like JDBC vs Hibernate to me. Yes, you can do it better in JDBC, but no, 99.99% of the users won't do it better. M2 is growing up, the central repo is getting cleaned up (spring's pom will help a lot in this).

Last time I tried to build drools and setup my idea environment and run all test cases... it took me 5 minutes ("mvn install idea:idea").
Last time I tried to build spring and setup my idea environment and run all test cases... I gave up

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 2, 2006

Juergen Hoeller commented

FWIW, our test cases are not meant to be run an IDE in their entirety. I never ever do this myself (using IDEA too, BTW); all I run in the IDE is individual tests. We never bothered with specific IDE support in our build (like Drools seems to have) simply because noone ever asked for it.

The only supported way of running our test cases is the "tests" target in our Ant script, which will work nicely out of the box provided that you use the "-with-dependencies" download, even without Internet connectivity. I firmly believe that rebuilding Spring and running the entire test suite should be done on the command line, and couldn't be simpler there.

That said, of course we could provide such command-line build facilities based on Maven 2 as well. I'm just arguing that the present build is perfectly sufficient for rebuilding and running the test suite on the command line, which is the definitive way of building and running tests in the first place.

Juergen

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Oct 27, 2006

Thomas Van de Velde commented

I very much like running unit tests in my IDE as it is much easier to select a subset of tests to execute. I also assume there's something wrong with tests that cannot be run in an IDE.

Btw, all this Maven bashing is rather ridiculous. Ant just doesn't do the job efficiently if you are looking for a reliable, standardized build in a complex enterprise environment that has to deal with many applications and complex dependencies.

-1 for this one

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 7, 2007

Rick Evans commented

Huh? How can this issue be 'in progress'? This issue is the lowest of low hanging fruit... there ain't nothing to do if you are addressing it.

Are you telling me you are actively doing nothing Ben? :)

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Feb 7, 2007

nebhale commented

It makes me feel good to think I'm doing something by doing nothing. Actually if I've got #6183 in progress this must be as well.

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Mar 8, 2007

nebhale commented

I'm resolving this issue as it was primarily a response to #6183 which is now resolved as well. The point has been taken and will not soon be forgotten.

@spring-projects-issues spring-projects-issues added type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) has: votes-jira Issues migrated from JIRA with more than 10 votes at the time of import labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 1.2.9 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has: votes-jira Issues migrated from JIRA with more than 10 votes at the time of import in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant