Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMSTemplate setDeliveryPersistent(boolean deliveryPersistent) javadoc incorrect [SPR-3983] #8663

Closed
spring-projects-issues opened this issue Oct 17, 2007 · 3 comments
Assignees
Labels
in: messaging status: backported type: enhancement
Milestone

Comments

@spring-projects-issues
Copy link
Collaborator

@spring-projects-issues spring-projects-issues commented Oct 17, 2007

Reidar Hörning opened SPR-3983 and commented

The javadoc of the method tells me:

"PERSISTENT" (1) or "NON_PERSISTENT" (2)

Relying on javax.jms.DeliveryMode:

static final int NON_PERSISTENT = 1;
static final int PERSISTENT = 2;

It may be confusing especially while using
JMSTemplate.setDeliveryMode(int deliveryMode)

Correct me if I am wrong.

Thanks,
Reidar


Referenced from: commits 9cc86a3, aa1babd

Backported to: 3.2.7

1 votes, 3 watchers

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jun 18, 2012

Rossen Stoyanchev commented

This issue has been resolved through a selective bulk update, as part of a larger effort to better manage unresolved issues. To qualify for the update, the issue was either created before Spring 3.0 or affects a version older than Spring 3.0 and is not a bug.

There is a good chance the request was made obsolete, or at least partly outdated, by changes in later versions of Spring including deprecations. It is also possible it didn't get enough traction or we didn't have enough time to address it. One way or another, we didn't get to it.

If you believe the issue, or some aspects of it, are still relevant and worth pursuing at present you may re-open this issue or create a new one with a more up-to-date description.

We thank you for your contributions and encourage you to become familiar with the current process of managing Spring Framework JIRA issues that has been in use for over a year.

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 21, 2014

Artem Bilan commented

There is similar forum request on the matter: http://forum.spring.io/forum/spring-projects/integration/jms/743711-incorrect-documentation-related-to-delivery-modes-in-jmstemplate
Why just not fix it? Change '1' to '2' and vice versa?
Thank you!

@spring-projects-issues
Copy link
Collaborator Author

@spring-projects-issues spring-projects-issues commented Jan 21, 2014

Juergen Hoeller commented

We didn't look at this issue specifically back then; it was buried among hundreds of open minor improvements.

This specific one is of course easy to fix, so thanks for pointing it out!

Juergen

@spring-projects-issues spring-projects-issues added in: messaging status: backported type: enhancement labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.0.1 milestone Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: messaging status: backported type: enhancement
Projects
None yet
Development

No branches or pull requests

2 participants