Remoting support for async calls methods with void return types [SPR-4427]

[spring-projects-issues]

Eric Simmerman opened SPR-4427 and commented

JMS Remoting does not currently support async calls nor does it support invocation of methods with void return types. This patch address both issues.

Async invocation is used automatically where the invoked method has void return type and no declared Exceptions. I simply set the replyTo queue to null and properly handle that through the invocation. Obviously I do not wait for any reply in the control flow.

To properly handle methods with checked exceptions but void return type, I inserted support for returning null from a remoting call.

---

Affects: 2.5.1

Attachments:

• JMS-Remoting-PATCH.txt (25.76 kB)
• JMS-Remoting-PATCH.txt (7.24 kB)

2 votes, 5 watchers

[spring-projects-issues]

Juergen Hoeller commented

This is a good idea but the "void plus no checked exception" policy feels a bit unclean - what if you're waiting for runtime exceptions, or just for a general "call returned so I know it happened" status?

I'd prefer to introduce this aligned with a general @Async annotation that clearly indicates a method as asynchronously invoked in the interface. The semantic contract is much clearer for the user as well as for the invocation infrastructure then, and may apply to other kinds of invocations as well - not just JMS invoker.

Juergen

[spring-projects-issues]

Eric Simmerman commented

Good feedback for the async policy. I'll put together an updated patch.

[spring-projects-issues]

Eric Simmerman commented

JMS Remoting support for asynchronous requests, DeliveryMode configuration, and message TTL using Annotations.

[spring-projects-issues]

Eric Simmerman commented

I modeled the runtime annotation support in my latest patch after the org.springframework.jmx.export.annotation package. Specifically, I extended the current JMSInvoker classes using the naming convention Annotation<Parent Class> and dropped the new child classes in tiger/src.

[spring-projects-issues]

Juergen Hoeller commented

Closing groups of outdated issues. Please reopen if still relevant.