Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make script source locator mechanism pluggable [SPR-5106] #9779

Closed
spring-projects-issues opened this issue Aug 20, 2008 · 1 comment
Closed
Assignees
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@spring-projects-issues
Copy link
Collaborator

spring-projects-issues commented Aug 20, 2008

Scott Leberknight opened SPR-5106 and commented

Currently ScriptFactoryPostProcessor's convertToScriptSource method allows only inline or Resource-based scripts. Suggest that ScriptFactoryPostProcessor should allow the script locator mechanism to be pluggable and allow scripts to be loaded from anywhere.

Something along the lines of extracting the convertToScriptSource() method in ScriptFactoryPostProcessor into a pluggable strategy, with perhaps a default if you don't want to do anything more than inline or Resource-based scripts. So maybe there would be a ScriptLocator interface which you could plug into the ScriptFactoryPostProcessor rather than needing to subclass SFPP and override the protected convertToScriptSource method, which I did to allow scripts to be loaded from a database.


Affects: 2.5.5

7 votes, 8 watchers

@spring-projects-issues
Copy link
Collaborator Author

spring-projects-issues commented Sep 22, 2015

Juergen Hoeller commented

Closing groups of outdated issues. Please reopen if still relevant.

@spring-projects-issues spring-projects-issues added status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement in: core Issues in core modules (aop, beans, core, context, expression) labels Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants