New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spr 15950 PathMatchingResourcePatternResolver.java cannot find any resources in jar file in weblogic and websphere #1523

Open
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@kk580kk

kk580kk commented Sep 11, 2017

In my project, I used this code to find resources in jar file. It works nice in tomcat and spring-boot:run but cannot find any resources in jar file in weblogic and websphere . So by read this stackoverflow https://stackoverflow.com/questions/17429736/spring-configuration-files-loading-not-working-on-websphere-7 I think rewrite PathMatchingResourcePatternResolver() maybe the best answer. Issue: SPR-15950 huangjie 2017/9/11 09:29

huangjie added some commits Sep 11, 2017

huangjie
In my project, I used this code to find resources in jar file. It wor…
…ks nice in tomcat and spring-boot:run but cannot find any resources in jar file in weblogic and websphere .

So by read this stackoverflow https://stackoverflow.com/questions/17429736/spring-configuration-files-loading-not-working-on-websphere-7
I think rewrite PathMatchingResourcePatternResolver() maybe the best answer.
Issue: SPR-15950
huangjie
In my project, I used this code to find resources in jar file. It wor…
…ks nice in tomcat and spring-boot:run but cannot find any resources in jar file in weblogic and websphere .

So by read this stackoverflow https://stackoverflow.com/questions/17429736/spring-configuration-files-loading-not-working-on-websphere-7
I think rewrite PathMatchingResourcePatternResolver() maybe the best answer.
Issue: SPR-15950
huangjie
@kk580kk

This comment has been minimized.

Show comment
Hide comment
@rstoyanchev

This comment has been minimized.

Show comment
Hide comment
@rstoyanchev

rstoyanchev Sep 11, 2017

Contributor

The entire source file is modified to use spaces. Can you fix your pull request to use tabs (as it was before) so it is possible to see what actually changed?

Contributor

rstoyanchev commented Sep 11, 2017

The entire source file is modified to use spaces. Can you fix your pull request to use tabs (as it was before) so it is possible to see what actually changed?

@kk580kk

This comment has been minimized.

Show comment
Hide comment
@kk580kk

kk580kk Sep 11, 2017

@rstoyanchev
I'll try to use tabs

kk580kk commented Sep 11, 2017

@rstoyanchev
I'll try to use tabs

huangjie
@kk580kk

This comment has been minimized.

Show comment
Hide comment
@kk580kk

kk580kk Sep 12, 2017

@rstoyanchev I have formatted the code now

kk580kk commented Sep 12, 2017

@rstoyanchev I have formatted the code now

huangjie and others added some commits Sep 12, 2017

huangjie
@lqjack

the exception should be throw and not swallow .

file scan can reuse the function framework provided

@kk580kk

This comment has been minimized.

Show comment
Hide comment
@kk580kk

kk580kk Sep 20, 2017

In this situation catch the MalformedURLException and fall back to normal function is the best choice. This change only for websphere and weblogic. @lqjack
Reuse the function framework provided maybe better answer. But could you tell me which function?

kk580kk commented Sep 20, 2017

In this situation catch the MalformedURLException and fall back to normal function is the best choice. This change only for websphere and weblogic. @lqjack
Reuse the function framework provided maybe better answer. But could you tell me which function?

@kk580kk kk580kk changed the title from Spr 15950 to Spr 15950 PathMatchingResourcePatternResolver.java cannot find any resources in jar file in weblogic and websphere Oct 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment