New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPR-16141 : SpEL: Fix equality under custom comparator #1581

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@triggerNZ

triggerNZ commented Nov 1, 2017

This is my first contribution to spring, so please advise if I have missed anything.

This PR fixes SPR-16141 by allowing equality checking to defer to the TypeComparator's canCompare, rather than hardcoding conditions.

@aclement

This comment has been minimized.

Show comment
Hide comment
@aclement

aclement Jan 20, 2018

Some feedback... I wouldn't create a new test class, just add the test to the existing SpelReproTests. Update the years for files changed and the author tags. For changes made to SpEL behavior these days you need to consider any impact on compiled SpEL. Do the changes to Operator mean changes to the isCompilableXX or generateComparisonCode methods? I can't remember what the compiler does for custom comparators.

aclement commented Jan 20, 2018

Some feedback... I wouldn't create a new test class, just add the test to the existing SpelReproTests. Update the years for files changed and the author tags. For changes made to SpEL behavior these days you need to consider any impact on compiled SpEL. Do the changes to Operator mean changes to the isCompilableXX or generateComparisonCode methods? I can't remember what the compiler does for custom comparators.

@GleyderC

This comment has been minimized.

Show comment
Hide comment
@GleyderC

GleyderC Jan 20, 2018

GleyderC commented Jan 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment