New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dropwizard metrics to spring-web http client #1610

Closed
wants to merge 1 commit into
base: 4.3.x
from

Conversation

Projects
None yet
3 participants
@xiaoshuang-lu

xiaoshuang-lu commented Dec 1, 2017

No description provided.

@pivotal-issuemaster

This comment has been minimized.

Show comment
Hide comment
@pivotal-issuemaster

pivotal-issuemaster Dec 1, 2017

@xiaoshuang-lu Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster commented Dec 1, 2017

@xiaoshuang-lu Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Show comment
Hide comment
@pivotal-issuemaster

pivotal-issuemaster commented Dec 1, 2017

@xiaoshuang-lu Thank you for signing the Contributor License Agreement!

@bclozel

This comment has been minimized.

Show comment
Hide comment
@bclozel

bclozel Feb 7, 2018

Member

Thanks for the PR, but we can't accept this change for several reasons, because this is:

  • adding a mandatory dependency on DW Metrics to all Spring Framework projects
  • already taken care of by Micrometer support in Spring Boot
Member

bclozel commented Feb 7, 2018

Thanks for the PR, but we can't accept this change for several reasons, because this is:

  • adding a mandatory dependency on DW Metrics to all Spring Framework projects
  • already taken care of by Micrometer support in Spring Boot

@bclozel bclozel closed this Feb 7, 2018

@xiaoshuang-lu

This comment has been minimized.

Show comment
Hide comment
@xiaoshuang-lu

xiaoshuang-lu Feb 8, 2018

@bclozel thanks for your comments. I placed metric stuff in a ClientHttpRequestInterceptor class finally.

xiaoshuang-lu commented Feb 8, 2018

@bclozel thanks for your comments. I placed metric stuff in a ClientHttpRequestInterceptor class finally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment