New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPR-7827 - first support for meta-annotations in integration test #219

Closed
wants to merge 2 commits into
base: 3.2.x
from

Conversation

Projects
None yet
3 participants
@giovannidalloglio
Contributor

giovannidalloglio commented Jan 24, 2013

related to issue: https://jira.springsource.org/browse/SPR-7827

prior this commit, there was no support for meta-annotations in the Spring Intergation tests, now the @ContextConfiguration annotation is searched also in meta-annotations.

Eg: you can write:

@ContextConfiguration([...]) // config for HSQLDB environment
public @interface InRamEnvironment
@ContextConfiguration([...]) // config for common-core part
public @interface CommonCoreIntegrationTest
@CommonCoreIntegrationTest
@InRamEnvironment
public class OneBatchTest {

[...] // actual test methods
}

giovannidalloglio added some commits Jan 24, 2013

first support for meta-annotations for the integration tests
Issue: SPR-7827

prior this commit, there was no support for meta-annotations in the Spring Intergation tests, now the @ContextConfiguration annotation is searched also in meta-annotations.

Eg: you can write:
---------------
@ContextConfiguration([...]) // config for HSQLDB environment
public @interface InRamEnvironment
---------------
@ContextConfiguration([...]) // config for common-core part
public @interface CommonCoreIntegrationTest
---------------
@CommonCoreIntegrationTest
@InRamEnvironment
public class OneBatchTest {

[...] // actual test methods
@giovannidalloglio

This comment has been minimized.

Show comment
Hide comment
@giovannidalloglio

giovannidalloglio Jan 31, 2013

Contributor

I'm sorry.

I forget to mention that this is the "correct and working" version of the previously closed pull request # 201 (as referenced by cbeams).

PS I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

Contributor

giovannidalloglio commented Jan 31, 2013

I'm sorry.

I forget to mention that this is the "correct and working" version of the previously closed pull request # 201 (as referenced by cbeams).

PS I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

@nealeu

This comment has been minimized.

Show comment
Hide comment
@nealeu

nealeu Feb 26, 2013

Chris, Sam: Any progress on when this'll get merged? It's a sweet feature 👍

nealeu commented Feb 26, 2013

Chris, Sam: Any progress on when this'll get merged? It's a sweet feature 👍

@giovannidalloglio

This comment has been minimized.

Show comment
Hide comment
@giovannidalloglio

giovannidalloglio Nov 22, 2013

Contributor

This pull request was superseed by #393

Contributor

giovannidalloglio commented Nov 22, 2013

This pull request was superseed by #393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment