Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationListenerMethodAdapter: gracefully handle beans which are actually NullBean #23784

Merged

Conversation

@stevenschlansker
Copy link
Contributor

stevenschlansker commented Oct 11, 2019

Currently, if you have an optional event listener (via a @bean method returning null)
this causes the event multicaster to explode violently. Now, we just safely skip it.

…ctually NullBean

Currently, if you have an optional event listener (via a @bean method returning `null`)
this causes the event multicaster to explode violently.  Now, we just safely skip it.
@stevenschlansker

This comment has been minimized.

Copy link
Contributor Author

stevenschlansker commented Nov 4, 2019

Any comments on this fix? We are eagerly anticipating having our code work as expected, and it seems unlikely to cause a regression.

@jhoeller jhoeller self-assigned this Nov 7, 2019
@jhoeller jhoeller added this to the 5.2.2 milestone Nov 7, 2019
@jhoeller jhoeller merged commit fc55e66 into spring-projects:master Nov 11, 2019
1 check passed
1 check passed
ci/pivotal-cla Thank you for signing the Contributor License Agreement!
Details
jhoeller added a commit that referenced this pull request Nov 11, 2019
@stevenschlansker stevenschlansker deleted the stevenschlansker:null-eventlistener-bean branch Nov 11, 2019
@stevenschlansker

This comment has been minimized.

Copy link
Contributor Author

stevenschlansker commented Nov 11, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.