From d1fedd9b4b33e2e8adaaf67abce46c9d07f923cb Mon Sep 17 00:00:00 2001 From: Clayton Walker Date: Thu, 6 Nov 2025 12:18:48 -0700 Subject: [PATCH] Add jar validation and fix multi-release jar Signed-off-by: Clayton Walker --- .../multirelease/MultiReleaseJarPlugin.java | 7 ++++ .../MultiReleaseJarValidateTask.java | 37 +++++++++++++++++++ .../core/task/VirtualThreadDelegate.java | 2 + .../ClassFileMetadataReaderFactory.java | 2 +- 4 files changed, 47 insertions(+), 1 deletion(-) create mode 100644 buildSrc/src/main/java/org/springframework/build/multirelease/MultiReleaseJarValidateTask.java diff --git a/buildSrc/src/main/java/org/springframework/build/multirelease/MultiReleaseJarPlugin.java b/buildSrc/src/main/java/org/springframework/build/multirelease/MultiReleaseJarPlugin.java index 9e9c871d05cf..bc4045c6e97f 100644 --- a/buildSrc/src/main/java/org/springframework/build/multirelease/MultiReleaseJarPlugin.java +++ b/buildSrc/src/main/java/org/springframework/build/multirelease/MultiReleaseJarPlugin.java @@ -27,6 +27,9 @@ import org.gradle.api.plugins.JavaPlugin; import org.gradle.api.plugins.JavaPluginExtension; import org.gradle.api.tasks.TaskContainer; +import org.gradle.api.tasks.TaskProvider; +import org.gradle.api.tasks.bundling.AbstractArchiveTask; +import org.gradle.jvm.tasks.Jar; import org.gradle.jvm.toolchain.JavaToolchainService; /** @@ -57,5 +60,9 @@ public void apply(Project project) { tasks, dependencies, objects); + TaskProvider validateJarTask = tasks.register("validateJar", MultiReleaseJarValidateTask.class, (task) -> { + task.getJar().set(tasks.named("jar", Jar.class).flatMap(AbstractArchiveTask::getArchiveFile)); + }); + tasks.named("check", task -> task.dependsOn(validateJarTask)); } } diff --git a/buildSrc/src/main/java/org/springframework/build/multirelease/MultiReleaseJarValidateTask.java b/buildSrc/src/main/java/org/springframework/build/multirelease/MultiReleaseJarValidateTask.java new file mode 100644 index 000000000000..75d237919e96 --- /dev/null +++ b/buildSrc/src/main/java/org/springframework/build/multirelease/MultiReleaseJarValidateTask.java @@ -0,0 +1,37 @@ +/* + * Copyright 2002-present the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.build.multirelease; + +import org.gradle.api.file.RegularFileProperty; +import org.gradle.api.tasks.CacheableTask; +import org.gradle.api.tasks.InputFile; +import org.gradle.api.tasks.JavaExec; +import org.gradle.api.tasks.PathSensitive; +import org.gradle.api.tasks.PathSensitivity; + +import java.util.List; + +@CacheableTask +public abstract class MultiReleaseJarValidateTask extends JavaExec { + @InputFile + @PathSensitive(PathSensitivity.RELATIVE) + public abstract RegularFileProperty getJar(); + public MultiReleaseJarValidateTask() { + getMainModule().set("jdk.jartool"); + getArgumentProviders().add(() -> List.of("--validate", "--file", getJar().get().getAsFile().getAbsolutePath())); + } +} diff --git a/spring-core/src/main/java21/org/springframework/core/task/VirtualThreadDelegate.java b/spring-core/src/main/java21/org/springframework/core/task/VirtualThreadDelegate.java index be6c83082af0..c57cb12b0d06 100644 --- a/spring-core/src/main/java21/org/springframework/core/task/VirtualThreadDelegate.java +++ b/spring-core/src/main/java21/org/springframework/core/task/VirtualThreadDelegate.java @@ -30,6 +30,8 @@ final class VirtualThreadDelegate { private final Thread.Builder threadBuilder = Thread.ofVirtual(); + public VirtualThreadDelegate() { } + public ThreadFactory virtualThreadFactory() { return this.threadBuilder.factory(); } diff --git a/spring-core/src/main/java24/org/springframework/core/type/classreading/ClassFileMetadataReaderFactory.java b/spring-core/src/main/java24/org/springframework/core/type/classreading/ClassFileMetadataReaderFactory.java index 553f1acd904b..0aab392609cf 100644 --- a/spring-core/src/main/java24/org/springframework/core/type/classreading/ClassFileMetadataReaderFactory.java +++ b/spring-core/src/main/java24/org/springframework/core/type/classreading/ClassFileMetadataReaderFactory.java @@ -30,7 +30,7 @@ * @author Brian Clozel * @since 7.0 */ -public class ClassFileMetadataReaderFactory extends AbstractMetadataReaderFactory { +class ClassFileMetadataReaderFactory extends AbstractMetadataReaderFactory { /** * Create a new ClassFileMetadataReaderFactory for the default class loader.