-
Notifications
You must be signed in to change notification settings - Fork 38.9k
Upgrade to json-path 2.10.0 #35924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Upgrade to json-path 2.10.0 #35924
Conversation
Signed-off-by: ivonaest <ivona.cvija@est.tech>
|
CVE-2024-57699 is irrelevant here as Spring Framework optionnally compiles against this dependency. Only applications depend on json-path. |
|
Hi @bclozel, while Spring is not vulnerable merging it is a small upgrade that would remote CVE from future security scans. Are you sure you don't want to merge it? |
|
@ivonaest I will merge it. I am just stating that this dependency will not show up in security scans because it is not declared in any of our artifacts. Only "spring-test" compiles against it and you can check that it does not depend on it in the published POM: https://central.sonatype.com/artifact/org.springframework/spring-test Upgrading dependencies is an important concern, but it's even more important to understand how dependency management works and whether a CVE is applicable. Here it is not. |
|
@bclozel Thank you for taking the time to explain CVE in this project. From my understanding, it is a false positive reported by Trivy scanner. |
|
Can you share the part where Trivy points to spring-test as the culprit? Trivy might be looking at the Gradle module information (where this dependency might show up) but is maybe missing the fact that it's not on the compile classpath. |
|
I don't understand why Trivy thinks spring-test has guava and other dependencies as transitive dependencies. Neither the POM file nor the Gradle module file lists anything like this. The If you can reach out to the Trivy team and get some answers, please let us know. |

Summary
Why:
To remove CVEs:
json-smartlibrary and can lead to denial-of-service through stack exhaustion when parsing malicious JSONWhat:
json-pathto 2.10.0 to remove CVE-2024-57699json-smartis a transitive dependency ofjson-pathand it needed 2.5.2+ versionjson-pathto 2.10.0,json-smartwas upgraded to 2.6.0Additional evidence
Partial output from security scanner Trivy:

Categorization