SPR-8308: OpPlus should convert operand values to String using registered converters #7

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

bedla commented Dec 18, 2011

implementation + unittest

Contributor

cbeams commented Feb 2, 2012

@aclement could you take a look at this? I'll assign the JIRA issue to you as well.

Contributor

cbeams commented Apr 30, 2012

Ivo, I'm looking at merging this pull request, but need to know that you've signed the SpringSource CLA. Please follow the instructions in the contributor guidelines and let us know you've filled out the form (it's easy and just takes a couple minutes).

Thanks!

Contributor

bedla commented Apr 30, 2012

Hi Chris,
I just signed the agreement as "Ivo Smid", do you want to send generated id?
Best regards
Ivos
Dne 30.4.2012 11:08 "Chris Beams" <
reply@reply.github.com>
napsal(a):

Ivo, I'm looking at merging this pull request, but need to know that
you've signed the SpringSource CLA. Please follow the instructions in the
contributor guidelines
and let us know you've filled out the form (it's easy and just takes a
couple minutes).

Thanks!


Reply to this email directly or view it on GitHub:

SpringSource#7 (comment)

Contributor

cbeams commented Apr 30, 2012

Thanks for the quick response! You don't need to post the generated ID here (but do keep track of it). On any future pull requests, you can just add the following line in a comment:

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

Note that I just updated the contributor guidelines document to make this clear.

@cbeams cbeams added a commit that referenced this pull request Apr 30, 2012

@cbeams cbeams Merge pull request #7 from bedla/SPR-8308
* SPR-8308:
  Convert SpEL plus operands using reg'd converters
e85e614
Contributor

cbeams commented Apr 30, 2012

This change has been merged, but note that several modifications were necessary:

  • The original commit added OpPlusTest under the old org.springframework.expression module. This has been corrected such that the test lives under the new spring-expression module.
  • OpPlusTest has been renamed to OpPlusTests to follow convention with the rest of the framework.
  • A number of whitespace changes were necessary. Particularly one line had trailing whitespace, which should always be avoided.
  • The @since tag on OpPlusTests was updated from 3.0 to 3.2
  • @author Ivo Smid tag added to OpPlus, as the contribution is significant enough to merit doing so.
  • The commit message was updated to adhere to the contributor guidelines.
  • @code tags now replace <code/> tags in Javadoc.
  • Javadoc now wraps at 90 characters.
  • The new OpPlus#convertTypedValueToString method visibility has been decreased from protected to private. This is to avoid adding new elements to the public API until it is deemed necessary. Users are free to request that this method be opened back up, based on legitimate use cases.

Most of the items above are covered in the contributor guidelines. Please review it completely before future submissions.

Thanks for the contribution, Ivo!

cbeams closed this Apr 30, 2012

Contributor

bedla commented Apr 30, 2012

You are welcome :-) Next time I will be more careful to satisfy contributor guidelines.

@bclozel bclozel added a commit that referenced this pull request Sep 22, 2014

@bclozel bclozel Merge pull request #7 from bclozel/forum
Update navbar item "Forum" -> "Questions"
1ca26df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment