SPR-5387 - If waitForTasksToCompleteOnShutdown is true then wait a confi... #96

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

tmeighen commented Jun 14, 2012

Hi,

I've written a patch and some test cases for SPR-5387. Please let me know if there are any issues.

I have signed and agree to the terms of the SpringSource Individual Contributor License Agreement.

t.

Contributor

cbeams commented Jun 15, 2012

Hi Tim,

Please read through and follow the [contributor guidelines|https://github.com/SpringSource/spring-framework/wiki/Contributor-guidelines], thanks.

cbeams was assigned Jun 15, 2012

Contributor

tmeighen commented Jun 15, 2012

Thanks Chris,

I'll take care of this today.

t.

Sent from my iPhone

On 2012-06-15, at 2:42 AM, Chris Beams
reply@reply.github.com
wrote:

Hi Tim,

Please read through and follow the [contributor guidelines|https://github.com/SpringSource/spring-framework/wiki/Contributor-guidelines], thanks.


Reply to this email directly or view it on GitHub:
SpringSource#96 (comment)

@tmeighen Tim Meighen Wait for tasks to complete if waitForTasksToCompleteOnShutdown is true
Prior to this commit, if waitForTasksToCompleteOnShutdown was true then a shutdown
would be called on the underlying ExecutorService but the caller would not wait for
running tasks to complete.

ExecutorConfigurationSupport and its subclasses will now wait a configurable number
of milliseconds for tasks to complete before issuing a hard shutdown.

Issue: SPR-5387
b15d9d1
Contributor

cbeams commented Jun 18, 2012

Thanks, Tim. Definitely looking better. Will take a deeper look as time allows.

Contributor

tmeighen commented Jan 23, 2013

Resolved by Juergen Hoeller: https://jira.springsource.org/browse/SPR-5387

tmeighen closed this Jan 23, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment