Ensure package-info.java in each package w/ @NullMarked
#304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first attempt at using JSpecify / Nullaway for nullability constraints missed many packages. This commit fixes that by adding a package-info.java to each package that is annotated w/ `@org.jspecify.NullMarked`. See spring-projects#192 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
Resolves spring-projects#192 Signed-off-by: onobc <chris.bono@gmail.com>
onobc
force-pushed
the
add-more-module-info
branch
from
cad5bef to
0256653
Compare
onobc
changed the title
@NullMarked
|
Hey @onobc, thanks for the work, looking great now :) The only other things that could take a bit more checking would be Generics / Wildcards, in Spring Framework, for example: repo:spring-projects/spring-framework "? extends @Nullable" Or more broadly repo:spring-projects/spring-framework "extends @Nullable" And in boot repo:spring-projects/spring-boot "extends @Nullable" But those checkings / additions would be better served in a dedicated PR, and I am not even sure now which cases would exist here in the repo, but regardless, a check for it would be nice because it could unravel some corner cases :) |
lobaorn-bitso
approved these changes
Nov 26, 2025
therepanic
approved these changes
Nov 26, 2025
Contributor
Author
|
Thank you both @therepanic @lobaorn-bitso I merged this in and will take a scan across generics in a subsequent movement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@therepanic @lobaorn-bitso PTAL