Skip to content
This repository has been archived by the owner on Jul 13, 2022. It is now read-only.

MissingConfigurationProcessorRule generates a false positive when the annotationProcessor configuration is used #266

Closed
wilkinsona opened this issue Apr 5, 2018 · 4 comments
Closed

MissingConfigurationProcessorRule generates a false positive when the annotationProcessor configuration is used #266

wilkinsona opened this issue Apr 5, 2018 · 4 comments
Labels
accepted
Milestone
3.9.5.RELEASE GA

Comments

@wilkinsona
Copy link
Contributor

See spring-projects/spring-boot#12316 (comment) for details.
@wilkinsona wilkinsona mentioned this issue Apr 5, 2018
Closed
@martinlippert martinlippert added this to the 3.9.5.RELEASE GA milestone Apr 11, 2018
@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Kris De Volder:)

I've created a sample gradle project that reproduces this issue. Attaching it here.

Import project as 'existing ecipse project' into STS 3.9.x (haven't tried STS 4, but i'm guessing its the same). A warning is shown in the 'MyProps' class although the annotation processor works when run from CLI.

Note that BuildShip has no support yet for actually properly configuring JDT APT and so props metadata is not actually generated in Eclipse.

This also makes it rather hard for us to verify whether the processor is present (we can not see it in Eclipse project). So I think we should wait for BuildShip to implement proper support for annotation processor configuratiion to allow for this rule to do proper validation. In the mean time our best option is probably to disable verification of this rule for Gradle projects.

See:

@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Kris De Volder:)

Confirmed. It shows in STS 4 too.

kdvolder added a commit that referenced this issue Jun 19, 2018
@kdvolder
Disable 'missing configuration processor' ...
b51b1e5 
This validation rule is disabled for gradle projects now,
to avoid false positives.

See: #266
@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Kris De Volder:)

Disabled the rule for projects with Gradle Buildship nature. Should keep an eye on the tickets in gradle / buildship for providing support to configre JDT APT automatically. If/when they do we can try to re-instate the validation of this rule and make it check classpath as well as processor path.

@spring-projects-issues
Copy link

(comment in Pivotal Tracker added by Kris De Volder:)

Delivering, verified it with STS 4 snapshot distro.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted
Milestone
3.9.5.RELEASE GA
Development

No branches or pull requests
3 participants
@martinlippert @wilkinsona @spring-projects-issues