New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MissingConfigurationProcessorRule generates a false positive when the annotationProcessor configuration is used #266

Closed
wilkinsona opened this Issue Apr 5, 2018 · 4 comments

Comments

Projects
None yet
3 participants
@wilkinsona
Member

wilkinsona commented Apr 5, 2018

@spring-issuemaster

This comment has been minimized.

spring-issuemaster commented Jun 19, 2018

(comment in Pivotal Tracker added by Kris De Volder:)

I've created a sample gradle project that reproduces this issue. Attaching it here.

Import project as 'existing ecipse project' into STS 3.9.x (haven't tried STS 4, but i'm guessing its the same). A warning is shown in the 'MyProps' class although the annotation processor works when run from CLI.

Note that BuildShip has no support yet for actually properly configuring JDT APT and so props metadata is not actually generated in Eclipse.

This also makes it rather hard for us to verify whether the processor is present (we can not see it in Eclipse project). So I think we should wait for BuildShip to implement proper support for annotation processor configuratiion to allow for this rule to do proper validation. In the mean time our best option is probably to disable verification of this rule for Gradle projects.

See:

@spring-issuemaster

This comment has been minimized.

spring-issuemaster commented Jun 19, 2018

(comment in Pivotal Tracker added by Kris De Volder:)

Confirmed. It shows in STS 4 too.

kdvolder added a commit that referenced this issue Jun 19, 2018

Disable 'missing configuration processor' ...
This validation rule is disabled for gradle projects now,
to avoid false positives.

See: #266

@spring-issuemaster spring-issuemaster added finished and removed started labels Jun 19, 2018

@spring-issuemaster

This comment has been minimized.

spring-issuemaster commented Jun 19, 2018

(comment in Pivotal Tracker added by Kris De Volder:)

Disabled the rule for projects with Gradle Buildship nature. Should keep an eye on the tickets in gradle / buildship for providing support to configre JDT APT automatically. If/when they do we can try to re-instate the validation of this rule and make it check classpath as well as processor path.

@spring-issuemaster

This comment has been minimized.

spring-issuemaster commented Jun 20, 2018

(comment in Pivotal Tracker added by Kris De Volder:)

Delivering, verified it with STS 4 snapshot distro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment