Permalink
Commits on Sep 23, 2016
  1. Fix the build and gitter badges

    * Move the Gitter badge to the line with the Build badge
    * Make Build badge as a link to the build
    * Fix Build badge to pointing to the correct build
    artembilan committed Sep 23, 2016
  2. Add Gitter badge

    gitter-badger committed Sep 23, 2016
Commits on Sep 22, 2016
  1. Mainly Checkstyle Violation Fixes

    * Upgrade to Checkstyle `7.1`
    * Relax `RequireThis` rule a bit. Right now it does the effort only in case of overlapping. See checkstyle/checkstyle#2362 for more info
    * Enable some annotation rules and provide fixes for violations
    * Enable `tabs indents` rule. This was the biggest fix in this PR
    * Resolve `TODO` in the `MessagingMethodInvokerHelper` and fix tests to meet `IllegalStateException` now
    
    Remain Checkstyle version `6.16.1` and reinstate `RequireThis` rule
    
    The latest Checkstyle has a bug with local scope variables if they have the same names as property.
    
    Revert some literals splitting
    
    Fix some line length exceeding and code style
    artembilan committed with garyrussell Sep 1, 2016
Commits on Sep 19, 2016
Commits on Sep 16, 2016
  1. INT-4106: Add JPA Java-based configuration docs

    JIRA: https://jira.spring.io/browse/INT-4106
    
    Also fix some typos in the `jpa.adoc` and remove mentioning of OpenJPA, since it doesn't support JPA 2.1
    artembilan committed Sep 16, 2016
Commits on Sep 15, 2016
  1. INT-4096: Allow Configuration of ReadOnly Headers

    JIRA: https://jira.spring.io/browse/INT-4096
    
    * Introduce `spring.integration.readOnly.headers` Integration property
    * Introduce `IntegrationMessageHeaderAccessor.setReadOnlyHeaders()` and use it from the overridden `IntegrationMessageHeaderAccessor.isReadOnly()`
    * Add `DefaultMessageBuilderFactory.setReadOnlyHeaders()` and delegate the value to the new `MessageBuilder.readOnlyHeaders()`
    * Modify `spring.integration.properties` for the `contentType` as a `readOnly` header for testing
    * Ensure that provided logic works via an appropriate modification to the `ObjectToJsonTransformerParserTests`
    
    Increase receive timeouts in the `OutboundGatewayFunctionTests`
    
    Fix `FileInboundTransactionTests` for slow `WatchService` issue on Linux/OS X
    
    Also redo the `tmp` dir logic to the `TemporaryFolder` `@ClassRule`
    
    Fix unused `import` in the `FileInboundTransactionTests`
    
    Polishing
    
    Conflicts:
    	spring-integration-core/src/main/java/org/springframework/integration/context/IntegrationProperties.java
    	spring-integration-core/src/main/resources/META-INF/spring.integration.default.properties
    
    Some polishing and documentation
    
    Localize `readOnly.headers` customization only in the `ObjectToJsonTransformerParserTests-context.xml`
    
    Otherwise ti might affect many other tests and the search for the reason of failure would be enough complicated
    
    Doc Polish
    artembilan committed with garyrussell Sep 13, 2016
  2. INT-4105: RedisLock: Unlock Local in `obtain()`

    JIRA: https://jira.spring.io/browse/INT-4105
    Fixes GH-1888
    
    The lock in Redis can be expired in between `obtain()` calls.
    So, even if we return a new lock instance, the old one must clear properly.
    
    * Add `lock.unlock()` to the `obtain()` if the case of expiration in Redis.
    * Add `warn` for the exception on the `lock.unlock()`. We don't care about error here and just proceed to a new instance.
    
    **Chery-pick to 4.3.x**
    
    Remove the lock reference from `weakThreadLocks` as well
    Add `registry.setUseWeakReferences(true);` to test-case
    
    * Add assert for `lock.unlock()` in case of expiration
    
    * Add `UUID.randomUUID()` for the registry key to avoid cross-talking during concurrent builds, e.g. on the CI server
    https://build.spring.io/browse/INT-MASTER-352
    
    This is actually a fix for the
    
    JIRA: https://jira.spring.io/browse/INT-4083
    artembilan committed with garyrussell Sep 2, 2016
  3. INT-4110: TestMailServer.ImapServer improve reply to FETCH ENVELOPE

    Frank Sigalas committed Sep 15, 2016
Commits on Sep 13, 2016
  1. INT-4109: Fix NPE in the `IntegrationGraphServer`

    JIRA: https://jira.spring.io/browse/INT-4109
    
    **Cherry-pick to 4.3.x**
    artembilan committed Sep 13, 2016
  2. INT-4108: Fix idempotency for some Lifecycles

    JIRA: https://jira.spring.io/browse/INT-4108
    
    Some `Lifecycle.start()/stop()` usage doesn't ensure robustness for components causing unexpected and difficulty tracing issues
    
    * Fix `Lifecycle.start()/stop()` for `FileReadingMessageSource`, `FileWritingMessageHandler`, `AbstractMqttMessageHandler`
    * In the `DefaultHeaderChannelRegistry`, `LockRegistryLeaderInitiator`, `MqttPahoMessageHandler` rework logic for shared variables to avoid `NPE`
    * Increase receive timeouts in the `PayloadDeserializingTransformerParserTests` and `UdpChannelAdapterTests`
    * Prove with the `WatchServiceDirectoryScannerTests` changes that several invocation for `FileReadingMessageSource.start()` are idempotent
    
    **Cherry-pick to 4.3.x**
    artembilan committed Sep 13, 2016
Commits on Sep 8, 2016
  1. Fix simple typo in `whats-new.adoc`

    Otherwise `Gateway Changes` section looks like sub-paragraph of the `JMS Changes`
    artembilan committed Sep 8, 2016
Commits on Sep 2, 2016
Commits on Sep 1, 2016
  1. Fix One More `Address already in use` Issue

    https://build.spring.io/browse/INT-MASTER-350
    
    There are so much other similar `SocketUtils` usage and it doesn't look so quickly to fix them all
    Let's do that on demand!
    Or just live with rebuild forever to believe that it was just a bad luck...
    
    Fix race condition when we assign the `port` for client before server actually has obtained the real port from OS
    artembilan committed with garyrussell Sep 1, 2016
Commits on Aug 31, 2016
  1. Lambdas - IP Module

    garyrussell committed Aug 31, 2016
  2. Some Fixes and Improvements

    * Remove `durable-subscription-name` from the `JmsMessageDrivenEndpointParser`, since we don't have such an attribute any more
    * Fix `configuration.adoc` for various typos
    * Remove `spring.integration.messagingAnnotations.require.componentAnnotation` and `spring.integration.messagingGateway.convertReceiveMessage` properties and their usage,
    since they are not actual any more starting with SI-5.0
    * Fix tests appropriately
    
    Address PR comments and more polishing
    
    Polishing
    artembilan committed with garyrussell Aug 31, 2016
Commits on Aug 29, 2016
  1. Apply Some Java 8 Code Changes

    * Make most functional interfaces as `@FunctionalInterface`
    * Convert some abstract classes to `@FunctionalInterface` with `default` methods
    * Apply Lambda style implementation in some places
    * Remove `Function` in favor of similar in Java 8
    
    *  Remove redundant code from `DefaultAmqpHeaderMapper` since we are already on Spring AMQP-2.0
    * Add several ctors to the `ExpressionEvaluatingMessageListProcessor`
    * Populate explicit `Boolean.class` `expectedType` from the `ExpressionEvaluatingReleaseStrategy`
    artembilan committed with garyrussell Aug 26, 2016
Commits on Aug 26, 2016
  1. INT-4103: Fix Amqp Channel Header Mappers

    garyrussell committed Aug 26, 2016
  2. INT-3913 Remove/resolve deprecation from the past

    JIRA: https://jira.spring.io/browse/INT-3913
    
    * Remove deprecated classes and methods/constructors, deprecated XML attributes
    * Remove `TcpConnectionEventListeningMessageProducer` and rework tests logic to the `ApplicationEventListeningMessageProducer`
    * Fix several typos
    * Remove/rework deprecated entities mentioning
    artembilan committed with garyrussell Aug 26, 2016
  3. INT-4095: Support Limiting (S)FTP Files Fetched

    JIRA: https://jira.spring.io/browse/INT-4095
    
    Limit the number of remote files fetched on each poll (when it is necessary to fetch files).
    
    Polishing - PR Comments
    
    Polishing - Decouple MaxFetchSize from Poller
    
    Polishing - PR Comments
    
    Schemas and Docs
    
    More Polishing
    
    * Polishing according PR comments
    garyrussell committed with artembilan Aug 18, 2016
Commits on Aug 24, 2016
  1. INT-4102: autoStartup = false for JMS container

    JIRA: https://jira.spring.io/browse/INT-4102
    
    There is inconsistency when we mark `JmsMessageDrivenEndpoint` for `autoStartup = false`,
    but external container can still be started by the application context, because of it own default `autoStartup = true`.
    
    * Mark `container` `autoStartup = false` in the `JmsMessageDrivenEndpoint` ctor to align lifecycles.
    
    **Cherry-pick to 4.3.x**
    artembilan committed Aug 24, 2016
Commits on Aug 23, 2016
  1. INT-4098: IMAP Content Rendering Consistency

    JIRA: https://jira.spring.io/browse/INT-4098
    
    Polishing - What's New
    
    Schema Polishing
    
    Also fix a test to align it with changes to the test mail server.
    garyrussell committed with artembilan Aug 17, 2016
  2. Ignore Exponential Moving Average Tests

    https://build.spring.io/browse/INT-SI43X-6/
    
    Since Exponential Moving Average algorithm is fully based on the time in between events, it is very difficult to reach the stable tests.
    All of them used to fail from time to time on the slow CI server.
    
    Mark all Exponential Moving Average Tests with `@Ignore`.
    
    The manual testing is required in case of some changes.
    
    **Cherry-pick to 4.3.x**
    artembilan committed Aug 23, 2016
  3. JdbcLRLeaderInitTests: increase latch timeouts

    https://build.spring.io/browse/INT-MASTER-338/
    
    Increase latch timeouts to 20 seconds in favor of assumption that there is some timing problems with embedded H2 on heavy-duty CI server
    artembilan committed Aug 23, 2016
  4. ZkLockRegistryTests: increase tryLock timeout

     https://build.spring.io/browse/INT-AT42SIO-253/
    
     ```
     java.lang.AssertionError: Should have been able to lock with zookeeper server restarted!
     	at org.junit.Assert.fail(Assert.java:88)
     	at org.junit.Assert.assertTrue(Assert.java:41)
     	at org.springframework.integration.zookeeper.lock.ZkLockRegistryTests.voidLockFailsWhenServerDown(ZkLockRegistryTests.java:339)
     ```
    
     When we do `testingServer.restart();` we should give more time to let it started on background, therefore increase the next `lock2.tryLock()` to 10 seconds.
    
     **Cherry-pick to 4.3.x and 4.2.x**
    artembilan committed Aug 23, 2016
Commits on Aug 22, 2016
  1. INT-4092: Add errorChannel Header with Void Return

    JIRA: https://jira.spring.io/browse/INT-4092
    
    Polishing
    
    Polishing
    
    Polish of Polishing
    garyrussell committed with artembilan Aug 19, 2016
  2. INT-4099: Fix `closableResource` typo

    JIRA: https://jira.spring.io/browse/INT-4099
    
    The `IntegrationMessageHeaderAccessor.CLOSEABLE_RESOURCE` value has a typo
    
    * Fix the typo in the `IntegrationMessageHeaderAccessor.CLOSEABLE_RESOURCE` constant value
    * Fix the same type in the (s)ftp.adoc
    artembilan committed Aug 19, 2016
  3. INT-4066: Expose RMI Factory Bean

    JIRA: https://jira.spring.io/browse/INT-4066
    
    Allow customization.
    
    Rename To RmiProxyFactoryBeanConfigurer
    
    Polishing
    
    More Polishing
    
    Polishing
    garyrussell committed with artembilan Aug 16, 2016
Commits on Aug 19, 2016
  1. INT-3941: Align JMS Config with Spring Boot

    JIRA: https://jira.spring.io/browse/INT-3941
    
    Previously, like the SF `<jms:/>` namespace, Spring Integration used a default bean
    name `connectionFactory` for the JMS Connection Factory.
    
    Spring Boot auto-configures a bean name `jmsConnectionFactory`.
    
    Since it is still common to use Spring Integration XML configuration with Spring Boot,
    it is useful to align the two so that an SI app can use the auto configured bean.
    
    Docs polishing
    
    Doc Polishing
    garyrussell committed with artembilan Aug 19, 2016
  2. INT-4062: Reject Exec. Channel Early Subscription

    JIRA: https://jira.spring.io/browse/INT-4062
    
    Only Enforce When an Executor is Provided
    
    With `ExecutorChannel` and `PublishSubscribeChannel` (when an executor is provided),
    any early subscription is lost because the dispatcher is replaced.
    
    checkstyle
    garyrussell committed with artembilan Aug 18, 2016
  3. INT-4069: Use AnnotatedElementUtils

    JIRA: https://jira.spring.io/browse/INT-4069
    
    Finding annotations with AnnotatedElementUtils allows us to use
    explicit annotation attribute overrides specified by the @AliasFor
    annotation.
    ghchapman committed with artembilan Jul 12, 2016
  4. Move TestMailServer to spring-integration-test

    garyrussell committed Aug 19, 2016