New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCP Client Connection Factory Improvements #2866
Comments
Hi @garyrussell , Shall i work on this item ? |
sure! You can take a crack on this and we together can see what to do else in your Pull Request! |
@artembilan I have couple of questions.
|
This is a non-trivial change (hence it's been on the backlog for a while). |
Thanks @garyrussell . Just to make sure I understand correctly. Instead of calling "this.clientConnectionFactory.getConnection() " from adapters, now we should extract the ip_connectionId from message and call this.clientConnectionFactory.getConnection(connectionId). If the connection is already created , then send that back or create a new one. Also we need to create a Map in AbstractClientConnectionFactory to hold multiple connections, since we dont have that. |
No; it should be optional only; by default use the existing Add a SpEL expression property; something like In most cases, yes, the expression will be Yes, we'll need a map of connections. |
Thanks @garyrussell . I will work on it. |
Add
getConnection(String connectionId)
so the client can select which connection it wants (if not open, returnnull
).Also
singleUse
serves 2 purposes when truegetConnection()
is calledSplit this into two flags
sharedConnection
andcloseAfterCompletion
.See https://stackoverflow.com/questions/55404438/programmatically-create-multiple-connections-for-tcpnetclientconnectionfactory/55404817#55404817
The text was updated successfully, but these errors were encountered: