Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractMailReceiver.class - - Mail Filter Expression - Not matched mails will NOT be discarded and flagged as seen. [INT-2991] #6968

Closed
spring-operator opened this issue Apr 11, 2013 · 2 comments
Assignees
Milestone

Comments

@spring-operator
Copy link
Contributor

Sven Illgen opened INT-2991 and commented

The method filterMessagesThruSelector (line 310) doesn't work as expected.

If you set a mail-filter-expression normally the not matched mails shouldn't be marked as seen, but they are marked as seen. On line 325 in AbstractMailReceiver all messages are added to the filteredMessage List. Looks like there is an else clause missing so that it will only be added if the filter expression matches or if there is no filter expression.

The Spring integration 2.1.x version contains this else clause in the receive method. See
https://github.com/SpringSource/spring-integration/blob/2.1.x/spring-integration-mail/src/main/java/org/springframework/integration/mail/AbstractMailReceiver.java

Line 272-287


Affects: 2.2.3

Reference URL: https://github.com/SpringSource/spring-integration/blob/master/spring-integration-mail/src/main/java/org/springframework/integration/mail/AbstractMailReceiver.java

@spring-operator
Copy link
Contributor Author

Gary Russell commented

Thanks for finding this (and the root cause).

Pull Request: #784

cherry-pick to 2.2.x

@spring-operator
Copy link
Contributor Author

Gunnar Hillert commented

Merged and cherry-picked to 2.2.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants