MongoDbMessageStore should provide a setter for messageTemplate [INT-3143]

[spring-operator]

MIhalcea Vlad opened INT-3143 and commented

It would be really usefull if the MongoDbMessageStore could provide a messageTemplate setter, since it's common to set up a singleton messageTemplate configured with custom convertors, and some other Mongo write-concern policies.

---

Issue Links:

• MongoDbMessageStore: ErrorMessage and AdviceMessage should be correctly converted to/from Store [INT-3077] #7059 MongoDbMessageStore: ErrorMessage and AdviceMessage should be correctly converted to/from Store
  ("is depended on by")
• Improve MongoDbMessageStore to properly store/restore existing Message<?> implementations [INT-3337] #7307 Improve MongoDbMessageStore to properly store/restore existing Message<?> implementations

[spring-operator]

MIhalcea Vlad commented

I realized the messageTemplate is final, so a constructor for setting it might be a good option, too.

[spring-operator]

Artem Bilan commented

MIhalcea Vlad,

Maybe do you mean MongoTemplate?
If you read MongoDbMessageStore more deeply, you notice that there is some internal MessageReadingMongoConverter and that's why customization of MongoTemplate isn't allowed.
There is need a lot of refactoring to accomplish more robust and flexible solution...
Nevertheless, thank you for pointing it out: to provide write-concern and some custom converters is a good request!

[spring-operator]

MIhalcea Vlad commented

Ok, I will investigate the MessageReadingMongoConverter than, and as for the write-concern I'll just follow your new developments.

[spring-operator]

Artem Bilan commented

IMO this issue relates to a big issue with Message conversions and its payload to/from Mongo

[spring-operator]

MIhalcea Vlad commented

Unfortunately, I couldn't supply my message template to the mongo storage, even following your suggestions. I've been having problems with how mongo stores my payloads, because I was having a message payload as an object grapgh, with cyclic references from parent to children, and mongo couldn't cope with that. And some headers were containing '.', which Mongo uses as a nested property selector. So, my workaround was to add 2 transformers, one taking my original message and serialize it as a payload to the mongo storage, and the other one for deserializing the payload and extracting the original message.
This addresses my converter issue part, but when it comes to customizing the write policy I am still out of options. Luckily my messages are not critical and loosing one won't affect the project, but if it were, I'd had to come up with a custom mongo db storage to inject my write-concern policy (replica-set journaling).

[spring-operator]

Artem Bilan commented

Try this:

DirectFieldAccessor dfa = new DirectFieldAccessor(mongoDbMessageStore);
MongoTemplate mongoTemplate = (MongoTemplate) dfa.getPropertyValue("template");
mongoTemplate.setWriteConcern(WriteConcern.REPLICAS_SAFE);

After application start up.

[spring-operator]

Amol Nayak commented

Preview PR Opened
#914

[spring-operator]

Artem Bilan commented

Revised PR: #969

[spring-operator]

Gary Russell commented

Merged