Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to configure FailoverClientConnectionFactory with CachingClientConnectionFactory (INT-3096) [INT-3497] #7465

Closed
spring-operator opened this issue Aug 14, 2014 · 2 comments
Assignees
Labels
in: TCP/UDP status: invalid Not reproducable or not relevant to the current state of the project

Comments

@spring-operator
Copy link
Contributor

spring-operator commented Aug 14, 2014

Kirill opened INT-3497 and commented

When I use both ways CachingClientConnectionFactory that contains FailoverClientConnectionFactory or FailoverClientConnectionFactory contains CachingClientConnectionFactory I'm getting a bottle neck in SimpleConnectionPool, because of synchronized methods in FailoverTcpConnection inner class. As findAConnection() and send(Message<?> message) are synchronized I'm getting a ConnectionPool with the only connection.


Affects: 4.0.3

Issue Links:

@spring-operator
Copy link
Contributor Author

Gary Russell commented

Can you explain further? I don't see a problem - see this test I just created - everything works fine, as expected.

The synchronization you talk about is at the connection level and has no impact on the pool. As you can see, I get 2 concurrent cached connections.

Bear in mind that the cache will only grow if you have concurrent work to do. If the IOs are very fast, it is difficult to get this to happen with anything except very large messages.

@spring-operator
Copy link
Contributor Author

Gary Russell commented

Closing due to lack of response; please request reopen if this is still an issue for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: TCP/UDP status: invalid Not reproducable or not relevant to the current state of the project
Projects
None yet
Development

No branches or pull requests

2 participants