Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in JSch [INT-3612] #7575

Closed
spring-operator opened this issue Jan 14, 2015 · 7 comments
Closed

Memory leak in JSch [INT-3612] #7575

spring-operator opened this issue Jan 14, 2015 · 7 comments
Assignees
Milestone

Comments

@spring-operator
Copy link
Contributor

Rob Moore opened INT-3612 and commented

We have experienced a memory leak in our product where IdentityFiles are repeatedly added to JSch's LocalIdentityRepository and never removed. Due to what appears to be a bug in JSch (a faulty contains() call on Vector), the redundant additions of the IdentityFile to the repository cause the key to be added each time JSch.addIdentity() is called.

I have opened a ticket on JSch (see reference URL) but there may some means to address this in SI itself (e.g., there is a getIdentityRepository() method in the JSch class that might be used to check for the identity using other means such as comparing the key blob field for each identity). I thought it was worth raising here for input.


Affects: 4.1.1

Reference URL: https://sourceforge.net/p/jsch/patches/8/

Referenced from: pull request #1438

@spring-operator
Copy link
Contributor Author

Gary Russell commented

Thanks for the heads-up. We'll track that issue and close this with an update to a new version.

I have generally found him to be responsive, but in the past I have contacted him directly using the email on his home page rather than using the sourceforge ticket system. There's not a whole lot of activity over there.

If you do contact him over email, please keep us up-to-date here.

If we don't get a fix from him in a reasonable time, we'll look at working around it, as you suggest.

Thanks

@spring-operator
Copy link
Contributor Author

Rob Moore commented

Thanks, Gary. I'll use the contact info you provided and let you know what I hear.

@spring-operator
Copy link
Contributor Author

Rob Moore commented

Atsuhiko Yamanaka responded to my email with a release candidate (http://www.jcraft.com/jsch/jsch-0.1.52-rc2.zip). We were able to confirm that this fixes the issue we were seeing with this component.

@spring-operator
Copy link
Contributor Author

Gary Russell commented

Excellent; thanks!.

We generally don't include release candidates in our GA dependencies, so we will wait for his 1.52 release.

In the meantime, users can choose to use the RC if they wish, overriding the default dependency.

Thanks again.

@spring-operator
Copy link
Contributor Author

Rob Moore commented

Understood. I expected you'd wait for the release but wanted to provide a link to the RC in case you are interested.

@spring-operator
Copy link
Contributor Author

Rob Moore commented

JSch 0.1.52 was just announced and it contains the fix for this issue.

@spring-operator
Copy link
Contributor Author

Gary Russell commented

4.1.4.RELEASE is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants