@InboundChannelAdapter Should Set MaxMessagesPerPoll to 1 by Default [INT-3657]

[spring-operator]

Gary Russell opened INT-3657 and commented

SPCA configured using xml gets max-messages-per-poll="1" by default.

@Bean
@InboundChannelAdapter(value = "fooChannel", poller = @Poller(fixedDelay="5000"))
public MessageSource<?> foo() {
...
}

Does not.

---

Referenced from: pull request #1391

[spring-operator]

Artem Bilan commented

Since basePollerType has just this:

<xsd:attribute name="max-messages-per-poll" type="xsd:string" />

With this fix we must add some description for this attribute and point that it is 1 for inbound-channel-adapter and -1 for any other PollingConsumer.
Consider the same for maxMessagesPerPoll attribute of the @Poller

[spring-operator]

Gary Russell commented

Yes; it's already talked about in the reference document but it's not mentioned in the schema docs; in fact the schema docs for basePollerType are very lacking.