Add generic arg to the GatewayProxyFactoryBean
#3925
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to spring-projects#3923 When gateway proxy is declared manually, a `GatewayProxyFactoryBean` is used as a `@Bean`. In this case the info about target interface is not available on a `BeanDefinition`, unlike with a programmatic registration via `MessagingGatewayRegistrar`. * Expose `<T>` on a `GatewayProxyFactoryBean` to make end-user to specify the type this gateway is going to be based on. This allows Spring container to determine the type of the `FactoryBean` bean definition properly * Migrate a programmatic bean definition registration from the `FactoryBean.OBJECT_TYPE_ATTRIBUTE` to the `targetType` property of the `BeanDefinition` based on a `ResolvableType.forClassWithGenerics()` to simulate generic arg for the application context * Remove `ComponentsRegistration` from the `GatewayProxySpec` since it us out of use * Fix affected tests for newly added generic arg on the `GatewayProxyFactoryBean`
|
Even if this looks like a breaking change, it is still legit for the current major release. |
Co-authored-by: Gary Russell <grussell@vmware.com>
|
This definitely looks helpful for a number of cases! |
garyrussell
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3923
When gateway proxy is declared manually, a
GatewayProxyFactoryBeanis used as a@Bean. In this case the info about target interface is not available on aBeanDefinition, unlike with a programmatic registration viaMessagingGatewayRegistrar.<T>on aGatewayProxyFactoryBeanto make end-user to specify the type this gateway is going to be based on.This allows Spring container to determine the type of the
FactoryBeanbean definition properlyFactoryBean.OBJECT_TYPE_ATTRIBUTEto thetargetTypeproperty of theBeanDefinitionbased on aResolvableType.forClassWithGenerics()to simulate generic arg for the application contextComponentsRegistrationfrom theGatewayProxySpecsince it us out of useGatewayProxyFactoryBean