Support Twitter API v1.1 in spring-integration-twitter #816

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Member

habuma commented Jun 5, 2013

Updated spring-integration-twitter's dependency on Spring Social Twitter to 1.0.4.BUILD-SNAPSHOT (and transitively to Spring Social Core to 1.0.3.BUILD-SNAPSHOT) to be able to use Twitter API 1.1.

Twitter API v1.0 will be retired on June 11, 2013, making this change necessary.

Note that although these dependencies are currently set to snapshot builds, I intend to push Spring Social Twitter 1.0.4.RELEASE and Spring Social Core 1.0.3.RELEASE builds on June 6, 2013. At that time, these dependencies can be updated accordingly.

Member

habuma commented Jun 5, 2013

If you do not merge this PR by the time I cut the Spring Social releases (core 1.0.3 and twitter 1.0.4), then I'll amend this PR to use those instead of the snapshots.

I plan to cut those releases tomorrow, barring any surprises.

Member

garyrussell commented Jun 5, 2013

We'll wait - the bigger concern is backporting to earlier release streams and getting a point release out in time.

Member

habuma commented Jun 5, 2013

I understand the concern (had the same concern on my end, as I'm already well into a 1.1.0 release stream). But know that without these changes, the Twitter stuff in SI will cease to work next Tuesday when Twitter shuts down v1.0 of their API (assuming that they don't postpone).

Member

habuma commented Jun 5, 2013

Well...I take that back...it won't necessarily quit working.

As long as the TwitterTemplate given to any subclass of AbstractTwitterMessageSource is an authorized (e.g., not created with the default constructor) instance, then it will still work.

If the TwitterTemplate was created with the default constructor, however, it will be of no use (I'll likely remove the default constructor in the 1.1.0 stream).

Member

markfisher commented Jun 5, 2013

Right and given that the default constructor is useless, then the change on Twitter's side will trigger breaking changes no matter what. Providing an upgrade version is not as important as being able to tell affected users that they need to use an authorized template.

This also means that only those using our twitter search adapters should be affected by these changes, correct?

In any case, we will provide a point release update after the spring-social-twitter GA is ready.

Member

habuma commented Jun 5, 2013

You're right, it should only impact those using the search adapters. The other Twitter adapters use operations that already required an authorized TwitterTemplate.

Member

habuma commented Jun 5, 2013

I've set aside tomorrow morning to cut the spring-social-twitter GA, so it should be ready (fingers crossed) early tomorrow. That said, if I'm not out too late tonight with my evening plans, I might pull the trigger tonight and just announce it tomorrow.

@markfisher markfisher added a commit that referenced this pull request Jun 7, 2013

@markfisher markfisher Merge pull request #816 from habuma
# By Craig Walls
* twitter-api-retire:
  Update Spring Social Twitter version to 1.0.4
1a27d81
Member

markfisher commented Jun 7, 2013

Merged into master. Still requires cherry-picking for 2.1.x and 2.2.x. However, I'm currently getting a bundlor error with 2.2.x. Investigating.

Member

markfisher commented Jun 8, 2013

Cherry picked to 2.2.x.

Member

markfisher commented Jun 10, 2013

Spring Social Twitter 1.0.5 was released this morning to address the lack of 3.0.x compatibility. I updated to that version across master (3.0.x) and both maintenance branches (2.1.x and 2.2.x). Now all builds have passed since applying those changes.

The bundlor issues were apparently not related to this upgrade (perhaps just a result of a dirty workspace after switching branches at build time).

markfisher closed this Jun 10, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment