From 3648eedd629839c68a7bf21fa3c413737ed9f008 Mon Sep 17 00:00:00 2001 From: JaeYeon Kim Date: Fri, 23 May 2025 01:45:49 +0900 Subject: [PATCH 1/2] #3917 A constructor that fails to validate null value properly Signed-off-by: JaeYeon Kim --- .../kafka/listener/CommonMixedErrorHandler.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spring-kafka/src/main/java/org/springframework/kafka/listener/CommonMixedErrorHandler.java b/spring-kafka/src/main/java/org/springframework/kafka/listener/CommonMixedErrorHandler.java index a5b604c3b5..11f863605a 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/listener/CommonMixedErrorHandler.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/listener/CommonMixedErrorHandler.java @@ -30,6 +30,7 @@ * for record and batch listeners. * * @author Gary Russell + * @auther JaeYeon Kim * @since 2.8 * */ @@ -46,7 +47,7 @@ public class CommonMixedErrorHandler implements CommonErrorHandler { */ public CommonMixedErrorHandler(CommonErrorHandler recordErrorHandler, CommonErrorHandler batchErrorHandler) { Assert.notNull(recordErrorHandler, "'recordErrorHandler' cannot be null"); - Assert.notNull(recordErrorHandler, "'batchErrorHandler' cannot be null"); + Assert.notNull(batchErrorHandler, "'batchErrorHandler' cannot be null"); this.recordErrorHandler = recordErrorHandler; this.batchErrorHandler = batchErrorHandler; } From e5185fca5c3ed322bb53d6ce7c664a98a4e4adf9 Mon Sep 17 00:00:00 2001 From: JaeYeon Kim Date: Fri, 23 May 2025 02:04:36 +0900 Subject: [PATCH 2/2] GH-3917: A constructor that fails to validate null value properly * Fixed a null check issue in the constructor of CommonMixedErrorHandler Signed-off-by: JaeYeon Kim --- .../springframework/kafka/listener/CommonMixedErrorHandler.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-kafka/src/main/java/org/springframework/kafka/listener/CommonMixedErrorHandler.java b/spring-kafka/src/main/java/org/springframework/kafka/listener/CommonMixedErrorHandler.java index 11f863605a..3d8bb0b8c0 100644 --- a/spring-kafka/src/main/java/org/springframework/kafka/listener/CommonMixedErrorHandler.java +++ b/spring-kafka/src/main/java/org/springframework/kafka/listener/CommonMixedErrorHandler.java @@ -30,7 +30,7 @@ * for record and batch listeners. * * @author Gary Russell - * @auther JaeYeon Kim + * @author JaeYeon Kim * @since 2.8 * */