Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Gradle #385

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
6 participants
@Am-Coder
Copy link

commented Jan 30, 2019

Attempting to migrate from maven to gradle build

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Jan 30, 2019

@Am-Coder Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-issuemaster

This comment has been minimized.

Copy link

commented Jan 30, 2019

@Am-Coder Thank you for signing the Contributor License Agreement!

@Am-Coder Am-Coder closed this Jan 30, 2019

@Am-Coder Am-Coder reopened this Jan 30, 2019

@snicoll snicoll changed the title From Maven To Gradle migration Add support for Gradle Jan 30, 2019

@snicoll

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Attempting to migrate from maven to gradle build

I think the plan is that we're considering adding Gradle support so removing Maven is not an option.

@Am-Coder

This comment has been minimized.

Copy link
Author

commented Jan 30, 2019

Got it!

Am-Coder added some commits Jan 30, 2019

@Am-Coder

This comment has been minimized.

Copy link
Author

commented Jan 30, 2019

I think its done.

@dsyer
Copy link
Member

left a comment

I think we need to remove the binary files in .gradle. There should be a gradle directory containing the wrapper, but nothing else is needed in source control.

@@ -1,2 +1,4 @@
language: java
jdk: oraclejdk8
before_install:
- chmod +x gradlew

This comment has been minimized.

Copy link
@dsyer

dsyer Mar 27, 2019

Member

Is this really necessary? It would be better to commit it with the right flags if possible (presumably it works for mvnw).

This comment has been minimized.

Copy link
@Lewiscowles1986

Lewiscowles1986 Jun 15, 2019

Is it really so important to not be explicit?

@dsyer
Copy link
Member

left a comment

Please use start.spring.io/build.gradle to generate a starting point.

}

dependencies {
compile 'org.springframework.boot:spring-boot-starter-actuator:2.1.1.RELEASE'

This comment has been minimized.

Copy link
@dsyer

dsyer Mar 27, 2019

Member

We should use the dependency management features in Spring Boot - no need for explicit versions in build.gradle.

@foxundermoon

This comment has been minimized.

Copy link

commented Apr 8, 2019

.gradle should ignore

@dsyer dsyer force-pushed the spring-projects:master branch from 9fe1647 to 912d2ad Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.