Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROO-3639: add renderLabel attribute in form fields tags #96

Merged
merged 3 commits into from Jul 17, 2015

Conversation

Projects
None yet
3 participants
@dlemaignent
Copy link
Contributor

commented Jul 10, 2015

Update form fields tags datetime, display, editor, input, select, simple, textarea to add renderLabel directive. This directive indicate if the contents of the label should be rendered.

renderLabel default value is true
When renderLabel is false, the label is hide

@jmvivo

This comment has been minimized.

Copy link
Collaborator

commented Jul 13, 2015

Please complete the online individual contributers agreement at https://support.springsource.com/spring_committer_signup so I can apply your patch.

@dlemaignent

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2015

Hy,

It's ok i have complete the individual agreement.

@jcagarcia

This comment has been minimized.

Copy link
Collaborator

commented Jul 14, 2015

I've just created the following JIRA task related with your improvement:

https://jira.spring.io/browse/ROO-3639

@jcagarcia jcagarcia changed the title NO-JIRA: add renderLabel attribute in form fields tags ROO-3639: add renderLabel attribute in form fields tags Jul 14, 2015

@jcagarcia

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2015

Hi @thepins,

I've been looking your proposal... and I think that is a great idea!!!

I have only one comment, if you set "renderLabel" attribute to false, you lost the distribution of the form:

Form distribution

You could solve it easily applying the following solution on every tagx:

         <label for="_${sec_field}_id">
          <c:choose>
            <c:when test="${empty renderLabel or renderLabel}">
              <c:out value="${label}" />
            :
            </c:when>
            <c:otherwise>
              &amp;nbsp;
            </c:otherwise>
          </c:choose>
        </label>

Form distribution with solution

Apply the changes above on this pull-request and I will accept it! ;)

Regards,

@dlemaignent

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2015

Hy @jcagarcia ,

Ok, thanks. I will apply this solution soon.

David

@dlemaignent

This comment has been minimized.

Copy link
Contributor Author

commented Jul 17, 2015

I applied the changes and tested with blank roo project

jcagarcia added a commit that referenced this pull request Jul 17, 2015

Merge pull request #96 from thepins/renderLabel
ROO-3639: add renderLabel attribute in form fields tags

@jcagarcia jcagarcia merged commit c46a8f4 into spring-projects:master Jul 17, 2015

@jcagarcia

This comment has been minimized.

Copy link
Collaborator

commented Jul 17, 2015

Thanks for your contribution!!!! :D

Your changes has been merged!

Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.