Feature/oauth2 error handler #87

wants to merge 5 commits into


None yet
2 participants

caseylucas added some commits Jun 10, 2013

@caseylucas caseylucas fixes SECOAUTH-409
Prevent IllegalArgument exceptions when invalid requests (including invalid query strings) are encountered.
An implication is that invalid requests cannot be redirected for oauth purposes.
@caseylucas caseylucas Merge remote-tracking branch 'upstream/master' 4ca170a
@caseylucas caseylucas Merge remote-tracking branch 'upstream/master' da515d9
@caseylucas caseylucas Handle non-oauth2 errors similar to RestTemplate
Update OAuth2ErrorHander to handle non-oauth2 errors in a similar
same way that RestTemplate does.  Now, OAuth2ErrorHandler only looks
at 4XX status codes and if it is not able to determine a reasonable
oauth2 error, it delegates to a different/default ErrorHandler.
@caseylucas caseylucas Fix code that wasn't using buffered response.
- Some code wasn't using the correct buffered response.
- Added test case to verify that custom ErrorHandlers can
consume the response body if needed.

dsyer commented Sep 18, 2013

There's an integration test failure with this change (in sparklr2). Can you take a look and see if you can tweak it a bit?

Sorry about the messy history (we got in a mess with gh-pages and had to back out some changes) - you should be able to rebase your changes back onto a new master and re-submit.


caseylucas commented Sep 20, 2013

I created new pull request (#97) with a cleaner history. I didn't see any errors from mvn test or mvn integration-test. Is there some other test that i missed?

caseylucas closed this Sep 20, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment