Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent using both authorizeRequests and authorizeHttpRequests #10573

Closed
marcusdacoregio opened this issue Dec 1, 2021 · 1 comment · Fixed by #10574
Closed

Prevent using both authorizeRequests and authorizeHttpRequests #10573

marcusdacoregio opened this issue Dec 1, 2021 · 1 comment · Fixed by #10574
Assignees
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Milestone

Comments

@marcusdacoregio
Copy link
Contributor

marcusdacoregio commented Dec 1, 2021

When users configure the SecurityFilterChain they can opt to use authorizeHttpRequests or authorizeRequests. Using both configurations does not make sense since they do the same thing.

Using authorizeHttpRequests is preferable now, since authorizeRequests is gonna be deprecated.

We should ensure that only one of them is configured inside the filter chain.

@marcusdacoregio marcusdacoregio added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Dec 1, 2021
@marcusdacoregio marcusdacoregio added this to the 6.0.0-M1 milestone Dec 1, 2021
@marcusdacoregio marcusdacoregio self-assigned this Dec 1, 2021
@marcusdacoregio marcusdacoregio changed the title Prevent having both AbstractSecurityInterceptor and AuthorizationFilter on filter chain Prevent having both FilterSecurityInterceptor and AuthorizationFilter on filter chain Dec 1, 2021
@marcusdacoregio marcusdacoregio changed the title Prevent having both FilterSecurityInterceptor and AuthorizationFilter on filter chain Prevent using both authorizeRequests and authorizeHttpRequests Dec 2, 2021
@rwinch
Copy link
Member

rwinch commented Dec 6, 2021

@marcusdacoregio Can you please ensure this version is updated to 5.7.0-M1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants