SEC-990: Clarify the semantics of the ConsensusBased ADM #1241

Closed
spring-issuemaster opened this Issue Sep 28, 2008 · 1 comment

1 participant

@spring-issuemaster

Willie Wheeler (Migrated from SEC-990) said:

Since “consensus” can mean either unanimous or else majority-rule (ignoring abstains), it may be unclear to people who are thinking that consensus = unanimous what the difference is between ConsensusBased and UnanimousBased. I would suggest adding a short bit of clarification to the class-level Javadoc; e.g.

“Consensus” here means majority-rule (ignoring abstains) rather than unanimous agreement (ignoring abstains). If you require unanimity, please see {@link org.springframework.security.vote.UnanimousBased}.

@spring-issuemaster

Luke Taylor said:

I’ve added your suggested patch to the class-level javadoc. The behaviour was already pretty clear from the description of the “decide” method, but some pople may not read that far :).

@spring-issuemaster spring-issuemaster added this to the 3.0.0 M1 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment