Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-1070: AbstractRetryEntryPoint always uses RetryWithHttpEntryPoint logger #1321

Closed
spring-issuemaster opened this issue Dec 30, 2008 · 1 comment

Comments

@spring-issuemaster
Copy link

@spring-issuemaster spring-issuemaster commented Dec 30, 2008

Brien Wheeler(Migrated from SEC-1070) said:

AbstractRetryEntryPoint has a static logger defined by RetryWithHttpEntryPoint.class, instead of using a non-static getLogger(getClass()) or an abstract Log getLogger() function that would be implemented in both RetryWithHttpEntryPoint and RetryWithHttpsEntryPoint to provide the correct class for logging.

The impact is that log messages for the RetryWithHttpsEntryPoint get logged under the RetryWithHttpEntryPoint logger.

@spring-issuemaster

This comment has been minimized.

Copy link
Author

@spring-issuemaster spring-issuemaster commented Mar 15, 2009

Luke Taylor said:

Thanks. I’ve converted it to use a non-static logger and call getClass().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.