Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SEC-1090: Default colours assumed, not set, in stylesheet #1341

spring-issuemaster opened this Issue Feb 1, 2009 · 2 comments


None yet
1 participant

Brian Ewins(Migrated from SEC-1090) said:

The stylesheet used for http://static.springframework.org/spring-security/site/ doesn’t set the background/foreground colours on the page as a whole, only on individual elements (and a background image with a transparent background on #contentBox). This means that the browser defaults show through, which don’t necessarily mix well with the green background they’re on on the sidebar, or the off-white they appear on in the main area.

Try setting the browser defaults to white text on a black background (a high contrast setup) and you’ll see what I mean – the site is illegible. You need to make the defaults explicit in maven-base.css:

body {
margin: 0px;
padding: 0px;
color: black;
background-color: white;

… and the site will read just fine.

NB while WCAG does suggest that /not/ setting background and foreground colours is a way to achieve accessibility ( http://www.w3.org/TR/2008/NOTE-WCAG20-TECHS-20081211/G148 ) that’s not whats happened here – colours are specified for links, for the background of sidebars etc, and there is a coloured background image in the main content area.

Luke Taylor said:

This is more an issue with the standard maven skin and the Spring version on sourceforge which the current site is based on. There is no maven-base.css in the project, though we can of course set up the same defaults in site.css.

I’ve edited the files for the existing deployed sites in-situ, but the chances are we won’t be using the maven-spring-skin for the next release unless someone gets a chance to update the look and feel to match the current incarnation of springsource.org. I’ll probably be falling back to a default site css file for the next release.

Luke Taylor said:

I’ve modified site.css, which should hopefuly do the trick in future deployments, until the maven skin is updated and we decide to use it again.

@spring-issuemaster spring-issuemaster added this to the 3.0.0 M1 milestone Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment