Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SEC-1160: Rename AuthenticationProcessingFilter, AuthenticationProcessingFilterEntryPoint, AbstractProcessingFilter etc #1409

spring-issuemaster opened this Issue May 11, 2009 · 0 comments


None yet
1 participant

Luke Taylor (Migrated from SEC-1160) said:

The name AuthenticationProcessingFilter dates from a time when it was the only login mechanism available. There are now many and the names are confusing for newcomers to the framework as they are all authentication processing filters (CAS, OpenID, form-based etc). I'd suggest the following name changes (keeping the originals but deprecated for the time being).

AbstractProcessingFilter -> AbstractAuthenticationProcessingFilter (this filter is always responsible for authentication processing)
AuthenticationProcessingFilter -> SimpleAuthenticationProcessingFilter or UsernamePasswordAuthenticationProcessingFilter (always processes a username and password submission).
AuthenticationProcessingFilterEntryPoint -> LoginPageUrlAuthenticationEntryPoint (redirects to a login page URL).
PreAuthenticatedProcessingFilterEntryPoint -> Http403ForbiddenEntryPoint (always sends a 403 forbidden response).

@spring-issuemaster spring-issuemaster added this to the 3.0.0 M1 milestone Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment