SEC-1202: Remove SpringSecurityFilter or at least doFilter() method #1453

Closed
spring-issuemaster opened this Issue Jul 20, 2009 · 1 comment

1 participant

@spring-issuemaster

Luke Taylor (Migrated from SEC-1202) said:

SpringSecurityFilter was a good idea in terms of avoiding duplicated code, but the doFilter() and doFilterHttp() methods make the stack trace double the size and thus harder to read. It also looks like the overhead from Spring Security's filter chain is more than it actually is.

@spring-issuemaster

Luke Taylor said:

I've replaced the use of SpringSecurityFilter with spring-web's GenericFilterBean. Also removed the init() and destroy() methods from FilterChainProxy which called the corresponding filter chain methods, contradicting the description in the Javadoc.

@spring-issuemaster spring-issuemaster added this to the 3.0.0 M2 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment