SEC-1286: toString misformatting for Acl.java #1535

Closed
spring-issuemaster opened this Issue Nov 6, 2009 · 1 comment

1 participant

@spring-issuemaster

Paul Pavlidis (Migrated from SEC-1286) said:

Line 348:

sb.append("parent: ").append((this.parentAcl == null) ? "Null" : this.parentAcl.getObjectIdentity().toString());

There should be a space after 'Null', as it stands you get output with "NullaclAuthorizationStrategy".

Example:

AccessControlEntryImpl[id: 3539; granting: true; sid: GrantedAuthoritySid[IS_AUTHENTICATED_ANONYMOUSLY]; permission: BasePermission[...............................R=1]; auditSuccess: false; auditFailure: false]
inheriting: true; parent: NullaclAuthorizationStrategy: org.springframework.security.acls.domain.AclAuthorizationStrategyImpl@1c7e73f; auditLogger: org.springframework.security.acls.domain.ConsoleAuditLogger@11efef0]

@spring-issuemaster

Luke Taylor said:

Thanks for spotting this. I've added in an extra "; " to separate the parts.

@spring-issuemaster spring-issuemaster added this to the 3.0.0.RC2 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment