Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SEC-1407: Refactor URL Matching to use RequestMatcher interface #1652

spring-issuemaster opened this Issue Feb 10, 2010 · 2 comments


None yet
1 participant

Luke Taylor (Migrated from SEC-1407) said:

At the moment classes like FilterChainProxy and DefaultFilterInvocationSecurityMetadataSource use a UrlMatcher and store a map of paths (patterns). They do the work of converting incoming URLs to lower case etc.

It would make more sense if they used RequestMatchers as the Map key, with Ant and Regex path matchers a special case. This would allow for more flexible request matching and also for cleaner code, as the matcher implementations would encapsulate the upper/lower case logic etc.

Luke Taylor said:

This has been done, making the code for DefaultMethodSecurityMetadataSource much simpler and opening up the possibility of using more flexible matching strategies in future.

@spring-issuemaster spring-issuemaster added this to the 3.1.0.M1 milestone Feb 5, 2016

This issue supersedes #1670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment