Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-1407: Refactor URL Matching to use RequestMatcher interface #1652

Closed
spring-projects-issues opened this issue Feb 10, 2010 · 2 comments
Closed

Comments

@spring-projects-issues
Copy link

@spring-projects-issues spring-projects-issues commented Feb 10, 2010

Luke Taylor (Migrated from SEC-1407) said:

At the moment classes like FilterChainProxy and DefaultFilterInvocationSecurityMetadataSource use a UrlMatcher and store a map of paths (patterns). They do the work of converting incoming URLs to lower case etc.

It would make more sense if they used RequestMatchers as the Map key, with Ant and Regex path matchers a special case. This would allow for more flexible request matching and also for cleaner code, as the matcher implementations would encapsulate the upper/lower case logic etc.

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Mar 4, 2010

Luke Taylor said:

This has been done, making the code for DefaultMethodSecurityMetadataSource much simpler and opening up the possibility of using more flexible matching strategies in future.

@spring-projects-issues
Copy link
Author

@spring-projects-issues spring-projects-issues commented Feb 6, 2016

This issue supersedes #1670

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant