Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEC-1423: Inefficient Pointcut Expression parsing in ProtectPointcutPostProcessor.java #1666

Closed
spring-projects-issues opened this issue Feb 25, 2010 · 1 comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Milestone

Comments

@spring-projects-issues
Copy link

Tudor Malene (Migrated from SEC-1423) said:

The ProtectPointcutPostProcessor.postProcessBeforeInitialization method parses each pointcut expression for each method of the present bean until it finds a match, which is highly inefficient.

The parsed pointcutExpressions can be cached in a LinkedHashSet when the pointcut is added ( see patch ), thus avoiding the parsing of the same expression for each method of the current bean.

@spring-projects-issues
Copy link
Author

Luke Taylor said:

Good idea. I've updated the code to add caching for both 3.1.x and 3.0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement type: jira An issue that was migrated from JIRA
Projects
None yet
Development

No branches or pull requests

1 participant