Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

SEC-1423: Inefficient Pointcut Expression parsing in ProtectPointcutPostProcessor.java #1666

spring-issuemaster opened this Issue Feb 25, 2010 · 1 comment


None yet
1 participant

Tudor Malene (Migrated from SEC-1423) said:

The ProtectPointcutPostProcessor.postProcessBeforeInitialization method parses each pointcut expression for each method of the present bean until it finds a match, which is highly inefficient.

The parsed pointcutExpressions can be cached in a LinkedHashSet when the pointcut is added ( see patch ), thus avoiding the parsing of the same expression for each method of the current bean.

Luke Taylor said:

Good idea. I've updated the code to add caching for both 3.1.x and 3.0.x.

@spring-issuemaster spring-issuemaster added this to the 3.1.0.M1 milestone Feb 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment