SEC-1449: HttpRequestResponseHolder has default method modifiers #1689

Closed
spring-issuemaster opened this Issue Mar 24, 2010 · 1 comment

1 participant

@spring-issuemaster

Benjamin Muschko (Migrated from SEC-1449) said:

I am trying to implement a custom org.springframework.security.web.context.SecurityContextRepository in my own package. When I tried to get the HttpServletRequest and HttpServletResponse from the org.springframework.security.web.context.HttpRequestResponseHolder I noticed that getRequest() and getResponse() have default method modifiers applied to them. From my point of view the modifiers should be public. For now I guess I have to put my custom implementation into a org.springframework.security.web.context package.

public SecurityContext loadContext(HttpRequestResponseHolder httpRequestResponseHolder) {
HttpServletRequest request = httpRequestResponseHolder.getRequest();
HttpServletResponse response = httpRequestResponseHolder.getResponse();
...
}

@spring-issuemaster

Luke Taylor said:

SEC-1439. Please search Jira before opening new issues.

@spring-issuemaster spring-issuemaster added this to the 3.0.3 milestone Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment