Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
SEC-1545: Missing I18N Keys in messages.properties #1787
spring-security-core's default message.properties is missing at least one i18n key (LdapAuthenticationProvider.badCredentials).
I haven't gotten time to look for others, and it would be nice to address other potentials. Unless the bug assignee beats me to it, in the next couple days I can write a quick script that will get all the missing ones. I will then post a patch for the messages that I can do (i.e. if there isn't already a translation I probably cannot submit a fix for that language).
Anyone viewing this bug can easily work around this issue by providing their own message.properties as outlined in the spring security reference .
Rob Winch said:
I have attached a zip file containing a unit test (I18nTests.groovy) that I wrote that determines missing i18n keys, and i18n keys that are not following the naming convention (i.e. the key starts with the name of the class it is in or a superclass of the file it is in). For convenience, I have also attached results from each of these tests. It also contains a patch with a fix for everything I could fix. Some of the missing keys I could not add since I do not speak the language it was translated to. This means that even after the patch is applied one of the tests fails. Lastly there is a file that states all the i18n keys that are still missing after applying the patch.
A few notes: