SEC-1560: AccessControlListTag should use PermissionEvaluator #1801

Closed
spring-issuemaster opened this Issue Sep 7, 2010 · 7 comments

1 participant

@spring-issuemaster

Thomas Champagne (Migrated from SEC-1560) said:

With the version 3.0, I think AccessControlListTag should use the new interface PermissionEvaluator to check the permission on an object.

I join a new AccessControlListTag that gets the permissionEvaluator from spring context. It is based on the current code.

@spring-issuemaster

Thomas Champagne said:

Do you think it is possible to integrate this feature in version 3.1 ?

@spring-issuemaster

Luke Taylor said:

Ok :).

I think it makes sense, since the code is effectively duplicated in PermissionEvaluator and it makes the tag implementation much simpler.

@spring-issuemaster

Thomas Champagne said:

Thank you Luke.

If you don't want to change the AccessControlListTag, you can add the possiblity to use the hasPermission method in the AuthorizeTag. Because the final problem is to check the permission on an object in a JSP page.
For example, it is not possible to call this with the 3.0 version :
where the book variable is provided from the page context.
I found this approch in the forum : http://forum.springsource.org/showthread.php?104518-hasPermission-in-sec-authorize

I saw the code of the version 3.1 and I think there is not a lot of changes to do this :
In the DefaultWebSecurityExpressionHandler, override the createEvaluationContextInternal method and create a WebSecurityEvaluationContext.
In this WebSecurityEvaluationContext, override the lookupVariable method and lookup variables in the page context.

Tell me your opinion about last solution and if I have time today, I will create a patch.

@spring-issuemaster

Luke Taylor said:

Yes, it occurred to me that the AccessControlTag is now essentially a subset of the EL functionality. I will have a look, but it will probably require some other changes since it isn't currently possible to use a custom SecurityExpressionHandler for web access.

@spring-issuemaster

Eric Rath said:

I'm trying to upgrade from 3.0.5 to 3.1.1, and ran into trouble with accesscontrollist's hasPermission attribute. It previously accepted integer bitmasks, or string values consisting of single permission names or a comma-delimited list of permission names. After upgrading, it now only accepts single permission names. Is this expected? It appears the change to AccessControlListTag.java after the change for this ticket removed the call that resolves the hasPermission attribute to a collection of Permission objects. I tried to view that ticket (#1798), but Jira returned a permission-denied response, so I'm posting a comment here.

I examined the 3.1.1 code, and can't find any potential execution path that would allow the hasPermission attribute value to be parsed into a collection of Permission objects without providing my own PermissionEvaluator instance. The current combination of AccessControlListTag and AclPermissionEvaluator only interprets the value as single permission name.

If I want to allow single permission names, comma-delimited lists of permission names, and integer bitmasks, is a custom implementation of PermissionEvaluator the appropriate and intended solution?

@spring-issuemaster

Rob Winch said:

I have logged SEC-2022 and SEC-2023. You can get around the issue by using the work posted on your forum post

@spring-issuemaster spring-issuemaster added this to the 3.1.0.RC3 milestone Feb 5, 2016
@spring-issuemaster

This issue relates to #2246
This issue relates to #2248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment